make webtest optional #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webtest pulls in dependencies like beautifulsoup4, lxml, soupsieve, and waitress. Most Pecan users do not need these dependencies, and these libraries increase users' security exposure. Make webtest an optional dependency.
|
Good idea, @ktdreyer - thanks for the PR! |
|
Thanks! |
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 6, 2022
* Update octavia from branch 'master'
to f45388643f0423199c9ac86a21a163e535cb0007
- Add WebTest as an indirect test dependency
Pecan has made webtest an optional dependency for testing only [1].
Since it is still used for testing we need to add it to our
test-requirements.txt.
[1]: pecan/pecan#140
Change-Id: I4a0985fc93aa071e68491fe60478bee903de39ed
openstack-mirroring
pushed a commit
to openstack/octavia
that referenced
this pull request
Jul 6, 2022
Pecan has made webtest an optional dependency for testing only [1]. Since it is still used for testing we need to add it to our test-requirements.txt. [1]: pecan/pecan#140 Change-Id: I4a0985fc93aa071e68491fe60478bee903de39ed
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 19, 2022
* Update magnum from branch 'master'
to cb40fb3685a7b4212974052c6f2244439ff8c036
- Add back pep8 test
In Change I523a4a85867f82d234ba1f3e6fad8b8cd2291182, the pep8 test was
accidentally dropped.
Fix up code so that pep8 passes.
In addition to that following change has been added here to unbreak CI:
Add WebTest as an indirect test dependency
Pecan has made webtest an optional dependency for testing only [1].
Since it is still used for testing we need to add it to our
test-requirements.txt.
[1]: pecan/pecan#140
Change-Id: I2f85adb4ef29a43389897c201e6152fd4c7be9d6
openstack-mirroring
pushed a commit
to openstack/magnum
that referenced
this pull request
Jul 19, 2022
In Change I523a4a85867f82d234ba1f3e6fad8b8cd2291182, the pep8 test was accidentally dropped. Fix up code so that pep8 passes. In addition to that following change has been added here to unbreak CI: Add WebTest as an indirect test dependency Pecan has made webtest an optional dependency for testing only [1]. Since it is still used for testing we need to add it to our test-requirements.txt. [1]: pecan/pecan#140 Change-Id: I2f85adb4ef29a43389897c201e6152fd4c7be9d6
openstack-mirroring
pushed a commit
to openstack/blazar
that referenced
this pull request
Aug 23, 2022
Pecan has made WebTest an optional dependency for testing only [1]. Since it is used for blazar unit testing, we need to add it to the test-requirements. The lower version bound is required by requirements-check. It is (arbitrarily) taken from the Queens' upper-constraints. [1] pecan/pecan#140 Change-Id: I67b730a21676a8191756effec7e15ab1895e1c95
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 23, 2022
* Update blazar from branch 'master'
to d02152fd9783a9bd34f72357a57ed4d6ab00d4c2
- Add WebTest as a test dependency
Pecan has made WebTest an optional dependency for testing only [1].
Since it is used for blazar unit testing, we need to add it to the
test-requirements.
The lower version bound is required by requirements-check.
It is (arbitrarily) taken from the Queens' upper-constraints.
[1] pecan/pecan#140
Change-Id: I67b730a21676a8191756effec7e15ab1895e1c95
AnishReddyRavula
pushed a commit
to ChameleonCloud/blazar
that referenced
this pull request
Jan 9, 2024
Pecan has made WebTest an optional dependency for testing only [1]. Since it is used for blazar unit testing, we need to add it to the test-requirements. The lower version bound is required by requirements-check. It is (arbitrarily) taken from the Queens' upper-constraints. [1] pecan/pecan#140 Change-Id: I67b730a21676a8191756effec7e15ab1895e1c95
AnishReddyRavula
pushed a commit
to ChameleonCloud/blazar
that referenced
this pull request
Jan 9, 2024
Pecan has made WebTest an optional dependency for testing only [1]. Since it is used for blazar unit testing, we need to add it to the test-requirements. The lower version bound is required by requirements-check. It is (arbitrarily) taken from the Queens' upper-constraints. [1] pecan/pecan#140 Change-Id: I67b730a21676a8191756effec7e15ab1895e1c95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webtest pulls in dependencies like beautifulsoup4, lxml, soupsieve, and waitress. Most Pecan users do not need these dependencies, and these libraries increase users' security exposure. Make webtest an optional dependency.
Fixes: #139