[pull] master from google:master #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.8.1+incompatible to 2.8.2+incompatible. - [Release notes](https://github.com/docker/distribution/releases) - [Commits](distribution/distribution@v2.8.1...v2.8.2) --- updated-dependencies: - dependency-name: github.com/docker/distribution dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.8.1+incompatible to 2.8.2+incompatible. - [Release notes](https://github.com/docker/distribution/releases) - [Commits](distribution/distribution@v2.8.1...v2.8.2) --- updated-dependencies: - dependency-name: github.com/docker/distribution dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.21+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.21...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.21+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.21...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
This seems to be related to a change in the klog library where the "v"
flag isn't defined until after InitFlags() is called. Defer the call of
setting the default verbosity until after we do that instead of during
init(). Fixes startup:
$ GO_FLAGS=-trimpath build/build.sh && _output/cadvisor -logtostderr
>> building cadvisor
go: downloading github.com/prometheus/common v0.38.0
panic: flag v set at github.com/google/cadvisor/cmd/cadvisor.go:105 before being defined
goroutine 1 [running]:
flag.(*FlagSet).Var(0xc00017a150, {0x1874460, 0x2213bc8}, {0x1866490, 0x1}, {0x15f0596, 0x22})
flag/flag.go:1031 +0x33a
k8s.io/klog/v2.InitFlags.func1(0xc0001ab2f0?)
k8s.io/klog/v2@v2.80.1/klog.go:439 +0x31
flag.(*FlagSet).VisitAll(0xc00032fa50?, 0xc0005e1c90)
flag/flag.go:458 +0x42
k8s.io/klog/v2.InitFlags(0x7fbe00b2f5b8?)
k8s.io/klog/v2@v2.80.1/klog.go:438 +0x45
main.main()
github.com/google/cadvisor/cmd/cadvisor.go:109 +0x36
Signed-off-by: Joe Groocock <me@frebib.net>
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.2.3 to 0.2.4. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Commits](cyphar/filepath-securejoin@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.2.3 to 0.2.4. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Commits](cyphar/filepath-securejoin@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Go 1.21 compatibility: Set verbosity after flag definition
….com/docker/distribution-2.8.2incompatible Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible in /cmd
…stribution-2.8.2incompatible
…cker-20.10.24incompatible
…r/docker-20.10.24incompatible
…/docker/distribution-2.8.2incompatible Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible
….com/docker/docker-20.10.24incompatible Bump github.com/docker/docker from 20.10.21+incompatible to 20.10.24+incompatible in /cmd
…es/github.com/docker/docker-20.10.24incompatible
….com/cyphar/filepath-securejoin-0.2.4 build(deps): bump github.com/cyphar/filepath-securejoin from 0.2.3 to 0.2.4 in /cmd
…es/github.com/cyphar/filepath-securejoin-0.2.4
…es/github.com/docker/docker-20.10.24incompatible
…/docker/docker-20.10.24incompatible Bump github.com/docker/docker from 20.10.21+incompatible to 20.10.24+incompatible
…es/github.com/cyphar/filepath-securejoin-0.2.4
…/cyphar/filepath-securejoin-0.2.4 build(deps): bump github.com/cyphar/filepath-securejoin from 0.2.3 to 0.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )