Reacting flow #274
Closed
Reacting flow #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…features added but nothign hooked up
…es, and Rgas init error
…lem with production
The primitive state was being filled with mass fractions for the species entries and then passed to GetConservativesFromPrimitives, but this function expects that the species entries of the primitive state contain molar densities. Because of this, the returned conserved state was incorrect and the resulting molar densities returned by computeNumberDensities were also incorrect, which then made the species production terms incorrect.
Three bug fixes here: 1) The units of the formation energy from the input file is J / mol, so we need to divide by the species weight (kg / mol) here to get the formation energy per unit mass. 2) The vector hw_ was sizes to have entries for all species and the contributions were not summed. We need hw_ to be a scalar field with the contributions from all species summed. 3) Sign error Note that this commit does not add the sensible enthalpy contribution (see Poinsot and Veynante, Theoretical and Numerical Combustion, 2005, eq. 1.62).
Species history update was out of order.
to energy eqn rhs in ReactingFlow::heatOfFormation. Not general b/c Cv is hardcoded. Just for investigation. Don't merge this.
…t vs full dof bugs
Three bugs were found and fixed while working on the low Mach analog to argon_minimal.binary.test. The fixes are 1) In ReactingFlow::speciesStep, set the initial guess for the iterative linear solve to the mass fraction for the current species from the previous time step. Because of how Yn_next_gf_ is managed, that was not the case and sometimes the electron species solve in particular struggled because of it. 2) Multiply the diffusivities returned by computeMixtureAverageDiffusivity by the mixture density (i.e., so that the diffision term in the species equation is div( \rho D \grad Y) ). 3) Populate the species entries of the primitive state in ReactingFlow::updateDiffusivity with the mole densities, rather than the mass fraction.
added 18 commits
April 28, 2024 17:35
…ion term now consistent with Poinsot book eq 1.67.
|
This PR has been replaced by #281. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of reacting-flow variant of thermo-chem. Currently only setup for Argon mixture without E-field contributions.