Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match IPv6 addresses as anonymous users #40

Merged
merged 1 commit into from Nov 11, 2013
Merged

Conversation

strainu
Copy link
Contributor

@strainu strainu commented Nov 4, 2013

@schmir
Copy link
Contributor

schmir commented Nov 11, 2013

thanks for your pull request.

doesn't the same argument as seen in #41 apply here? are IPv6 addresses valid usernames?

@strainu
Copy link
Contributor Author

strainu commented Nov 11, 2013

I don't think so. I've tried to create users 2001::a and 2001:a:b:c:d:e:1:2 and they were rejected as invalid. Perhaps a weird, cornercase address would work, but that would be a bug (IPv4 addresses definitely don't work ). Even if such a user would be able to register, it would still be against the policies on most WMF projects.

@schmir schmir merged commit 745f256 into pediapress:master Nov 11, 2013
@schmir
Copy link
Contributor

schmir commented Nov 11, 2013

Thanks, I've merged that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants