Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #528

Merged
merged 2 commits into from May 16, 2024
Merged

Fix typos #528

merged 2 commits into from May 16, 2024

Conversation

szepeviktor
Copy link
Contributor

Found misspellings.

$expression = $gettext->parenthesize_plural_exression( $this->plural_expression );
$expression = $gettext->parenthesize_plural_expression( $this->plural_expression );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedro-mendonca How about this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method has been deprecated. Use Plural_Forms() instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But only for v6.5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locales.php file is a clone from GlotPress. This should be reported upstream.

Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pedro-mendonca
Copy link
Owner

Thanks for the fix 👍

@pedro-mendonca pedro-mendonca merged commit f6fcb2e into pedro-mendonca:master May 16, 2024
12 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the typos branch May 16, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants