Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB2 stays half open forever after being tripped open once #1

Closed
v-yarotsky opened this issue May 20, 2015 · 3 comments
Closed

CB2 stays half open forever after being tripped open once #1

v-yarotsky opened this issue May 20, 2015 · 3 comments

Comments

@v-yarotsky
Copy link

Hi
It looks like CB2 can never become fully closed after being opened once. Here's a failing test.

The rolling window strategy's #half_open? is pretty much the opposite of #open?, which is not what it is supposed to represent.

I was thinking of having a success callback in a strategy, which would reset last_open if the circuit breaker is currently half-open. This would solve the issue in a single-threaded case, although in a hacky manner, but there are going to be issues with concurrent clients (cranking up number of WORKERS in the test to 50 or so exposes the issue).

@jphenow
Copy link

jphenow commented May 2, 2016

I think this is closeable now?

@victorhazbun
Copy link

@pedro

@prognostikos
Copy link
Owner

Looks like this was fixed in v0.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants