You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi
It looks like CB2 can never become fully closed after being opened once. Here's a failing test.
The rolling window strategy's #half_open? is pretty much the opposite of #open?, which is not what it is supposed to represent.
I was thinking of having a success callback in a strategy, which would reset last_open if the circuit breaker is currently half-open. This would solve the issue in a single-threaded case, although in a hacky manner, but there are going to be issues with concurrent clients (cranking up number of WORKERS in the test to 50 or so exposes the issue).
The text was updated successfully, but these errors were encountered:
Hi
It looks like CB2 can never become fully closed after being opened once. Here's a failing test.
The rolling window strategy's
#half_open?
is pretty much the opposite of#open?
, which is not what it is supposed to represent.I was thinking of having a
success
callback in a strategy, which would resetlast_open
if the circuit breaker is currently half-open. This would solve the issue in a single-threaded case, although in a hacky manner, but there are going to be issues with concurrent clients (cranking up number ofWORKERS
in the test to 50 or so exposes the issue).The text was updated successfully, but these errors were encountered: