Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update push_notification.rb #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muzammalaslam
Copy link

Default notification option change

Default notification option change
@antillas21
Copy link
Contributor

Hi @muzammalaslam , could you provide a little context regarding the reason behind this change?

@muzammalaslam
Copy link
Author

muzammalaslam commented Jun 23, 2017 via email

@antillas21
Copy link
Contributor

Thanks for the clarification @muzammalaslam 😄

Does this look good to you @pedroandrade ?

@pedroandrade
Copy link
Owner

Sounds great @muzammalaslam and @antillas21

@muzammalaslam could you fix the spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants