[FIX]Readd missing controls on duplicate default_code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems checks does not fully test the code. At this point, we need to figures out what wrong with the code, the checks or the tests.
…oduct kanban view.
Product brand improvements
8.0 product gtin tests
…ty to calculate weight for multi products
- remove leftover comments - do not redefine volume, but add fields before it - reindent - remove unneeded priority
Otherwise they are shown as weights.
Also, spell "height" correctly.
extract product_dimensions from ingadhoc/odoo-addons
Add missing default oca icons
Those part dispappeared from the PR and was present in the OCA repo. This code reintegrate the missing part OCA#57 (comment)
….0-product_images
|
Hi @pedrobaeza I rebased the code so that the PR will be able to pass. |
|
This is not needed, Florent, I just need to rebase to get last changes, so I close. |
|
Hi @pedrobaeza Thanks, I'm not such aware of rebase and all the stuff. I currently repull all the forked repo in mine and then push. I suppose that's not the best way to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those part dispappeared from the PR and was present in the OCA repo.
This code reintegrate the missing part
OCA#57 (comment)