Kirby 3: template settings override defaults instead of being merged

[LeBenLeBen]

With the Kirby 3 plugin, there seems to be a difference in how template settings are combined with default settings.

Consider:

c::set('pedroborges.metatags.default', function($page, $site) {
  return [
    'og' => [
      'title' => $page->metatitle(),
      'type' => 'website',
      'site_name' => $site->title(),
      'url' => $page->url(),
      'description' => $page->metadescription(),
      'locale' => explode('.', kirby()->language()->locale())[0],
      'namespace:image' => [...],
    ],
  ];
});

Coupled with:

c::set('pedroborges.metatags.templates', function($page) {
  return [
    'project' => [
      'og' => [
        'namespace:image' => [...],
      ],
    ],
  ];
});

The og tags on a page with a template project contains only those defined in the templates settings, not the defaults.

With the Kirby 2 version, the template specific settings used to be merged with the default. Now they seems to simply replace them.

[pedroborges]

Thank you for the huge contribution @LeBenLeBen! Just merged you PRs.

[LeBenLeBen]

@pedroborges Thank you for your time reviewing and releasing 2.0, much appreciated 🙇

[pedroborges]

You are welcome.

I have changed the option name to match the one used in v1.1.1 (with a dash). Update it your config after upgrading:

• pedroborges.meta-tags.default
• pedroborges.meta-tags.templates