Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works only for one page #21

Closed
qwerdee opened this issue Feb 27, 2020 · 0 comments · Fixed by #23
Closed

Works only for one page #21

qwerdee opened this issue Feb 27, 2020 · 0 comments · Fixed by #23

Comments

@qwerdee
Copy link
Contributor

qwerdee commented Feb 27, 2020

In the current implementation, the first instance of MetaTags gets cached and and this instance gets reused even if one requests a MetaTags instance for a different page.

metaTags($pageA) // creates an instance and caches it as static variable
metaTags($pageB) // returns this very same object

Instead a new instance should be created for each page and maybe cached separately

qwerdee added a commit to qwerdee/kirby-meta-tags that referenced this issue Feb 27, 2020
qwerdee added a commit to qwerdee/kirby-meta-tags that referenced this issue Feb 27, 2020
@qwerdee qwerdee changed the title Works only for page Works only for one page Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant