Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rtnetlink no such file #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix rtnetlink no such file #15

wants to merge 4 commits into from

Commits on Feb 6, 2024

  1. Remove pcap.c file which should be autogenerated

    @leoplo
    leoplo committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    efbb7b0 View commit details
    Browse the repository at this point in the history

  2. Fix: properly remove interfaces on stop command 

    On stop command call Main.stop() runs
`remove_interface("*", pim=True, membership=True, ipv4=True, ipv6=True)`.

Therefore if a PIM interface was added for network interface eth0, the call
`remove_interface('eth0', True, True)` will evaluate the condition
`membership and not membership_interface` as True and the PIM interface will
never be removed.

Furthermore
`remove_interface("*", pim=True, membership=True, ipv4=True, ipv6=True)` will
do calls like `remove_interface('lo', True, True)` then calling
`remove_virtual_interface('lo')` and the line
`index = self.vif_name_to_index_dic.pop(interface_name, None)` will cause a
KeyError when running
`del self.vif_name_to_index_dic[self.vif_index_to_name_dic[index]]` or
`mif_index = self.vif_name_to_index_dic.pop(interface_name)`.
    @leoplo
    leoplo committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5666800 View commit details
    Browse the repository at this point in the history

  3. Fix: check mrule existence before deletion 

    Avoid message: "RTNETLINK answers: No such file or directory"
    @leoplo
    leoplo committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9cb1b14 View commit details
    Browse the repository at this point in the history

  4. Fix: clean mrule entries on interface removal

    @leoplo
    leoplo committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    54791bd View commit details
    Browse the repository at this point in the history