Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar is to low at iPhone X(s/R) #13

Closed
kay4ik opened this issue Jun 13, 2019 · 4 comments
Closed

Bar is to low at iPhone X(s/R) #13

kay4ik opened this issue Jun 13, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@kay4ik
Copy link

kay4ik commented Jun 13, 2019

At the Bottom of the iPhone X... is the Navigation "Line". At this point there should be white space. The Navy Bar is behind this Line.

image

How it should look:

image

@pedromassango pedromassango added the bug Something isn't working label Jun 13, 2019
@pedromassango
Copy link
Owner

pedromassango commented Jun 13, 2019

Hi Kay4ik, can you try please too wrap the BottomNavyBar with a SafeArea widget? I don't have a Mac to try it. Thank you

@kay4ik
Copy link
Author

kay4ik commented Jun 14, 2019

Hey @pedromassango,
I tried and it works 👍

image

Here is my Code:

Container(
      decoration: BoxDecoration(
        color: Colors.white,
        boxShadow: [
          BoxShadow(
            offset: Offset(0,6),
            blurRadius: 6,
            spreadRadius: 8,
            color: Colors.grey,
          )
        ]
      ),
      child: SafeArea(
        child: BottomNavyBar(
          showElevation: false,
          ...

I wrapped the SafeAre in a Container to color the Area below the Navybar white.
When showElevation: true then the Bar shows the Elevation on top AND on bottom.
This is how it looks without Container and with ELevation:

image

@pedromassango
Copy link
Owner

Great. Thank you for this @kay4ik. Maybe you want to make a pull request with this contribuition?!

Or I can just do it by my self. Thanks

@pedromassango
Copy link
Owner

Fixed since this version: 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants