Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated null safety #20

Merged
merged 10 commits into from Mar 10, 2021

Conversation

nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented Mar 7, 2021

Description

I propose this pull request to migrate this plugin to null safety as it is the way to go now that Flutter 2 has been released.

Here are the changes I introduced:

  • Update SDK dependency version to 2.12.0+
  • Run dart migrate on existing code to remove unsafe nulls (for the package & example)
  • Add a new version (3.0.0) to the changelog (as recommended)
  • Migrated in the example to the new TextTheme version

Please check everything twice!

Testing

  • Tested it manually on a Android emulator

Related tickets

Closes #19

Copy link
Owner

@pedromassango pedromassango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this after that nit change.

This was referenced Mar 8, 2021
Copy link
Owner

@pedromassango pedromassango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@pedromassango pedromassango merged commit 086b684 into pedromassango:master Mar 10, 2021
@pedromassango
Copy link
Owner

New version avalible. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to null safety
2 participants