New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated null safety #20
Merged
pedromassango
merged 10 commits into
pedromassango:master
from
nilsreichardt:migrated-null-safety
Mar 10, 2021
Merged
Migrated null safety #20
pedromassango
merged 10 commits into
pedromassango:master
from
nilsreichardt:migrated-null-safety
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute<Object>?' in type cast "
pedromassango
requested changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this after that nit change.
This was referenced Mar 8, 2021
Merged
nilsreichardt
commented
Mar 9, 2021
pedromassango
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
New version avalible. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose this pull request to migrate this plugin to null safety as it is the way to go now that Flutter 2 has been released.
Here are the changes I introduced:
2.12.0+
dart migrate
on existing code to remove unsafe nulls (for the package & example)3.0.0
) to the changelog (as recommended)Please check everything twice!
Testing
Related tickets
Closes #19