Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve react warnings in ErrorReporter #465

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Resolve react warnings in ErrorReporter #465

merged 1 commit into from
Nov 23, 2018

Conversation

jossmac
Copy link
Contributor

@jossmac jossmac commented Nov 22, 2018

Description

Getting errors from the ErrorReporter makes it difficult to see the actual error that's occurring. This PR resolves those errors.

  • <div> cannot appear as a descendant of <p>
  • Each child in an array or iterator should have a unique "key" prop

Screenshots

Before After
Image Image
image

- `div` is invalid descendent of `p`
- no keys on mapped children
@pedronauck pedronauck changed the base branch from master to dev November 23, 2018 13:40
@pedronauck pedronauck merged commit 1b0e09d into doczjs:dev Nov 23, 2018
@jossmac jossmac deleted the patch-1 branch December 6, 2018 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants