Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docz-theme-default): add dark mode 🌚 #81

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Conversation

pedronauck
Copy link
Member

Description

This pull request adds support for dark mode on docz-default-theme on the fly just by changing themeConfig.mode on doczrc.js, like that:

export default {
  themeConfig: {
    mode: 'dark',
  },
}

Review

  • Fix: remove global css config
  • Chore: Add Docz footer logo as react component
  • Chore: Add new default components
  • Chore: Change default themeConfig
  • Feat: Add themeConfig.mode config on docz-theme-default

Pre-merge checklist

  • Test changing themeConfig.mode on the fly
  • Test adding and removing doczrc.js

Screenshots



* 'master' of github.com:pedronauck/docz: (36 commits)
  v0.2.11
  fix: some changes on css examples
  fix(docz-plugin-css): production build
  fix(docz-core): node env for production
  fix(docz-theme-default): use webfontloader instead of css import
  chore: update readme
  v0.2.10
  chore(docz-plugin-css): typo readme
  chore(docz-plugin-css): change readme
  feat(docz-plugin-css): add initial version (#78)
  chore: update badges on readme
  chore: update readme
  chore: contributing typos
  chore: add code conduct
  chore: update readme
  chore: update contributors
  chore: update readme
  chore: add contributing and contributors
  chore: add commitizen
  chore: add husky, lint staged and commitlint
  ...
@pedronauck pedronauck changed the title Feat/dark mode feat(docz-theme-default): add dark mode Jun 22, 2018
@pedronauck pedronauck changed the title feat(docz-theme-default): add dark mode feat(docz-theme-default): add dark mode 🌚 Jun 22, 2018
@pedronauck
Copy link
Member Author

@marceloavf @renatorib what do you think?

Copy link
Contributor

@marceloavf marceloavf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contrast and colors @pedronauck, really like it!
It seems like everything is on point.

@pedronauck pedronauck merged commit 964cf4d into dev Jun 25, 2018
@pedronauck pedronauck deleted the feat/dark-mode branch June 25, 2018 02:33
pedronauck added a commit that referenced this pull request Jun 25, 2018
* feat(docz-theme-default): include toggle to sidebar

* fix(docz-theme-default): made container responsive

* fix(docz-theme-default): change background based on toggle

* chore(docz-theme-plugin): add facepaint package

* feat(docz-theme-default): include media queries facepaint

* fix(docz-theme-default): responsive position for wrapper

* fix(docz-theme-default): include breakpoints as const

* feat(docz-theme-default): include ToggleBackground

* fix(docz-theme-default): change chevronDown to burguer icon with animation

* fix(docz-theme-default): lint code

* feat(docz-theme-default): table responsive

* fix(docz-theme-default): sidebar toggle for links and sub-links

* feat(docz-theme-default): include breakpoints reactive on sidebar

* feat(docz-theme-default): add dark mode 🌚 (#81)

* SAVEPOINT
* feat(docz-theme-default): add dark mode 🌚

* chore(docz-theme-default): some responsive adjustments

* v0.3.0-beta.0

* fix(docz-theme-default): prettier format

* v0.3.0
pedronauck added a commit that referenced this pull request Jun 26, 2018
* 'dev' of github.com:pedronauck/docz:
  v0.3.0
  fix(docz-theme-default): prettier format
  v0.3.0-beta.0
  chore(docz-theme-default): some responsive adjustments
  feat(docz-theme-default): add dark mode 🌚 (#81)
  feat(docz-theme-default): include breakpoints reactive on sidebar
  fix(docz-theme-default): sidebar toggle for links and sub-links
  feat(docz-theme-default): table responsive
  fix(docz-theme-default): lint code
  fix(docz-theme-default): change chevronDown to burguer icon with animation
  feat(docz-theme-default): include ToggleBackground
  fix(docz-theme-default): include breakpoints as const
  fix(docz-theme-default): responsive position for wrapper
  feat(docz-theme-default): include media queries facepaint
  chore(docz-theme-plugin): add facepaint package
  fix(docz-theme-default): change background based on toggle
  fix(docz-theme-default): made container responsive
  feat(docz-theme-default): include toggle to sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants