Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS declaration for Promise of new "react" method #1561

Merged
merged 1 commit into from Jul 10, 2022

Conversation

rokkit
Copy link
Contributor

@rokkit rokkit commented Jul 1, 2022

Without explicit delaration of void for returning Promise the tsc assembly throws an error

node_modules/whatsapp-web.js/index.d.ts:707:38 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).

Without explicit delaration of void <T> for Promise running tsc causing the error:

```
node_modules/whatsapp-web.js/index.d.ts:707:38 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).
```
index.d.ts Show resolved Hide resolved
Copy link
Sponsor Collaborator

@PurpShell PurpShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@pedroslopez pedroslopez merged commit e7025ce into pedroslopez:main Jul 10, 2022
Belfio pushed a commit to Belfio/whatsapp-web.js that referenced this pull request Jan 9, 2024
Without explicit delaration of void <T> for Promise running tsc causing the error:

```
node_modules/whatsapp-web.js/index.d.ts:707:38 - error TS2314: Generic type 'Promise<T>' requires 1 type argument(s).
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants