fix: Fix call event listener name + Added Call example #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuyuribr
approved these changes
Dec 23, 2022
dlimars
pushed a commit
to somosversotech/whatsapp-web.js
that referenced
this pull request
Feb 22, 2023
|
LGTM - Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
The event listener
'onIncomingCall'was incorrectly sending to'incoming_call'rather than'call'.And I've also added an example to help understand the feature.
Motivation and Context
It will allow for a more uniform typing, as the TS declaration uses
'call'How Has This Been Tested
I have tested this fix locally on my fork of the project.
Types of changes
Checklist