Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vcards from code, and remove eslint errors to allow merge #2170

Closed
wants to merge 1 commit into from
Closed

fix vcards from code, and remove eslint errors to allow merge #2170

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 25, 2023

PR Details

Fix for vCard parsing copied from #1995
I don't know why exactly not merged but I saw it didn't pass ESLint check so I updated it with fixes for ESLint
since I need whatsapp-web.js up to date on my bot, while being able to send vcards, I must update the code manually each time I update it, so I think we need to merge this in case other people needs it

Description

The module vcardFromContactModel doesn't contain parseVcard and vcardGetNameFromParsed functions anymore.
They can be found in the module WA_BIZ_NAME.

Motivation and Context

The vCard was not display, the content of the vCard was sent to Whatsapp chat.

How Has This Been Tested

on my personal whatsapp account

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@ghost ghost marked this pull request as ready for review April 25, 2023 11:26
@gkp1
Copy link

gkp1 commented Apr 26, 2023

I thought it was an error on my end, but you seem to have missed one function replacement from #1995 here:
This makes your commit not work.

image

@ghost ghost closed this Apr 27, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant