Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Puppeteer version to avoid warn from npm while installation #2259

Closed
wants to merge 2 commits into from

Conversation

M-Umais-Hassan
Copy link

PR Details

Having a warning from npm while installing the library and after that issue, the installations just kept stuck.

Description

Problem:

So, when I was trying to download the library I was having a warning from npm, and after having the warning the installation hang up and nothing was happening at all further.
Here is the warning message that I am having,
"npm info run puppeteer@13.7.0 install node_modules/whatsapp-web.js/node_modules/puppeteer node install.js"

Solution:

After some debugging, I just found that inside devDependencies we have an old version of puppeteer so I just updated it from 13.6.0 to 20.5.0 and it worked fine after the updation.

How Has This Been Tested

So, I have tested is by creating an instance of whatsapp web and its all running perfectly fine.

Types of changes

  • Dependency change
  • Breaking change (fix or feature that would cause existing functionality to change)

@tuyuribr
Copy link
Collaborator

tuyuribr commented Jun 7, 2023

#2129

@M-Umais-Hassan
Copy link
Author

M-Umais-Hassan commented Jun 7, 2023

Seems like an acceptable solution, but what if we have a project with an old version setup and don't want to upgrade the node for that? Just thinking of a scenario because I just had a similar one, so isn't it a better solution to upgrade the puppeteer and it will work fine hopefully for all the versions?

@tuyuribr tuyuribr closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants