fix: Contact #2325

alechkos · 2023-07-02T15:14:27Z

PR Details

- Description

- Motivation and Context

- Related Issues

- How Has the PR Been Tested

The environment the PR was tested on
I want to test this PR
I have an issue while testing this PR

- Types of Changes

Description

Fixes for Contact class:

Client.getContactById() method now retreives the valid contact info
Contact.block() method fixed to block a contact
The value of Contact.isBlocked property changes after the block() or unblock() methods are called

Added inner function to compare between two WWeb versions.
Its purpose is to provide a compatibility between old code implementations and a new updates made for the library to be synced with the newer WWeb versions. The thing will ensure the stable work for WWebJS no matter what version of WWeb is used.

Motivation and Context

After the WWeb v2.2327.4 the contact data structure has been modified causing some of the Contact class field values to be undefined, so it would be nice to fix an issue and keep this lib up-to-date with the latest WWeb version.

Related Issues

PR fixes #2299 fixes #2312

How Has This Been Tested

The code used in tests:

client.on('message', async (message) => {
    if (message.body === '!test') {
        const contact = await client.getContactById(message.author ?? message.from);
        console.log(contact);
        console.log('TRYING TO BLOCK...');
        await contact.block();
        console.log(`CHECKING IF BLOCKED...\n${contact.isBlocked}`);
        console.log('TRYING TO UNBLOCK...');
        await contact.unblock();
        console.log(`CHECKING IF UNBLOCKED...\n${contact.isBlocked}`);
    }
});

Tested On

Types of accounts:

Personal
Buisness

Environment:

Android 10
Windows 10:
- WWebJS v1.21.0
- WWeb v2.2327.4
- Node v16.17.1
- Chrome 114.0.5735.199

To test this PR by yourself you can run one of the following commands:

# NPM
npm install github:alechkos/whatsapp-web.js#fix-contact
# YARN
yarn add github:alechkos/whatsapp-web.js#fix-contact

If you encounter any issues while testing this PR, please provide in a comment:

The code you've used without any sensitive information (use syntax highlighting for more readability)
The library version
The WWeb version: console.log(await client.getWwebVersion());
The browser (Chrome/Chromium)
The error you got

Types of Changes

Dependency change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My code follows the code style of this project.
I have updated the documentation accordingly (index.d.ts).

The function compares the currently used WWeb version with the version that requires the code changes. Its purpose is to ensure the stable operation of the library across different WWeb versions.

T3uZ · 2023-07-02T22:15:49Z

Boa noite, funcionou perfeitamente aqui, obrigado.

ivanzigoni · 2023-07-03T13:21:59Z

hi.
just tested the pr and it seems to be working fine, although some contact's fields (labels, sectionHeader, statusMute, verifiedLevel and verifiedName) are still undefined but since i don't know exactly what they refer to, i guess that's just how it is?

edit: it also fixes the client.getContacts() and probably any other calls that returns Contact or Contact[].

alechkos · 2023-07-03T15:48:12Z

@ivanzigoni

although some contact's fields (labels, sectionHeader, statusMute, verifiedLevel and verifiedName) are still undefined

Thank you for your test,
labels, sectionHeader, statusMute, verifiedLevel and verifiedName are expected to be undefined if they do not have a value in your contact object.

PedroLGaldino · 2023-07-03T17:37:53Z

It still returns the contact as undefined, when sending the contact to another contact and saving it in the mysql database, it worked perfectly before.

alechkos · 2023-07-03T17:41:09Z

@PedroLGaldino

It still returns the contact as undefined, when sending the contact to another contact and saving it in the mysql database, it worked perfectly before.

Provide the code you used

PedroLGaldino · 2023-07-03T17:45:40Z

ok

alechkos · 2023-07-03T17:49:38Z

@PedroLGaldino
what wweb version do you use?

console.log(await client.getWWebVersion());

did you run npm install github:alechkos/whatsapp-web.js#fix-contact?

PedroLGaldino · 2023-07-03T17:50:22Z

@PedroLGaldino qual versão do wweb vc usa?
console.log(await client.getWWebVersion());
você correu npm install github:alechkos/whatsapp-web.js#fix-contact?

Yes:

{
"dependencies": {
"mysql2": "^3.4.3",
"qrcode-terminal": "^0.12.0",
"whatsapp-web.js": "github:alechkos/whatsapp-web.js"
}
}

alechkos · 2023-07-03T17:53:59Z

@PedroLGaldino
Can you run

console.log(await client.getWWebVersion());
console.log(await client.getContactById(/** number@c.us */);

and send the output without sensitive information?

PedroLGaldino · 2023-07-03T18:05:29Z

console.log(await client.getWWebVersion());
console.log(await client.getContactById(/** number@c.us */);

PrivateContact {
id: {
server: 'c.us',
user: 'x',xxxxxxxxxxxxx
_serialized: xxxxxxxxxxx@c.us'
},
number: undefined,
isBusiness: undefined,
isEnterprise: undefined,
labels: undefined,
name: undefined,
pushname: 'Client',
sectionHeader: undefined,
shortName: undefined,
statusMute: undefined,
type: 'in',
verifiedLevel: undefined,
verifiedName: undefined,
isMe: undefined,
isUser: undefined,
isGroup: undefined,
isWAContact: undefined,
isMyContact: undefined,
isBlocked: false
}

The contact appears in the log. So I'm getting it wrong in my code

alechkos · 2023-07-03T18:09:14Z

@PedroLGaldino what about this?

console.log(await client.getWWebVersion());

PedroLGaldino · 2023-07-03T18:12:09Z

@PedroLGaldinoe quanto a isso?
console.log(await client.getWWebVersion());

Sorry 2.2327.4

alechkos · 2023-07-03T18:23:31Z

@PedroLGaldino

2.2327.4

Is it a buisiness contact? Because i havent checked the fix on buisiness contacts yet

PedroLGaldino · 2023-07-03T18:24:39Z

@PedroLGaldino

2.2327.4

Is it a buisiness contact? Because i havent checked the fix on buisiness contacts yet

Yes its a bussines acount and bussines contact. So I'll wait for the solution, if you need help I'm available

alechkos · 2023-07-03T18:26:31Z

@PedroLGaldino

Yes its a bussines acount and bussines contact. So I'll wait for the solution, if you need help I'm available

Thank you for your tests, ill check later and make required changes

alechkos · 2023-07-04T10:56:59Z

@PedroLGaldino i made some changes so you can test it, please let me know if you have issues

Matheus-Lima-Moreira

Just worked fine for me, i had some issues recently with wwebjs that multiplied some groups generating a new group with a new id, this group was recognized as a contact and received the new messages, while the old one only sent, after this patch the problem is fixed.
wwebjs version test was 1.21 and 1.95

dottovip · 2023-07-05T18:12:49Z

It works for me. Thanks

diegofemello · 2023-07-06T21:35:04Z

worked for me, thanks

hldpzz · 2023-07-07T18:53:38Z

Worked here, thank you very much!

fenchai23 · 2023-07-10T01:09:31Z

bro where is the merge🤨

T3uZ · 2023-07-10T19:40:06Z

Mais alguem com problemas para baixar no ??
npm install github:alechkos/whatsapp-web.js#fix-contact

Mr-Nobody1 · 2023-07-28T18:02:16Z

works fine on my machine but when I try to do it on VM it shows me this

alechkos · 2023-07-28T18:11:01Z

@Mr-Nobody1

when I try to do it on VM it shows me this

The error you got is unrelated to this PR, check your git/npm settings on the VM

Mr-Nobody1 · 2023-07-29T07:27:51Z

@Mr-Nobody1

when I try to do it on VM it shows me this

The error you got is unrelated to this PR, check your git/npm settings on the VM

Ok I was able to install it and it works fine. Thanks

shirser121 · 2023-07-30T20:28:15Z

@pedroslopez @PurpShell

shirser121

LGTM

* fix: Contact (pedroslopez#2325) * fixed: contact info retrieving * fixed: block method * fixed: isBlocked property is now changeble * added inner function to compare between WWeb versions The function compares the currently used WWeb version with the version that requires the code changes. Its purpose is to ensure the stable operation of the library across different WWeb versions. * added: todo remove useOldImplementation * improved inner function to compare WWeb versions * inner function: added support for beta versions * added support for business accounts * module queries changed to strings * fixed check for wweb beta versions * updated to throw a custom error message * minor changes in inner function * feat: send photo/video as a view once message (pedroslopez#2317) * added isViewOnce property * docs updated * added usage example * fix: ESLint * feat: add new link with phone option without regen observer * feat: implement code regeneration observer * chore: revert .gitignore change * chore: .gitignore EOF * refactor: replace wrong `LinkingOption` param type with `object` * refactor: make qr handler use the new `linkingMethod.qr.maxRetries` * test: add new test cases for linking method * refactor: improve new code checking * test: replace number with a number provided in the `.env` * refactor: improve constructor typing * refactor: make never properties optional --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com>

* fixed: contact info retrieving * fixed: block method * fixed: isBlocked property is now changeble * added inner function to compare between WWeb versions The function compares the currently used WWeb version with the version that requires the code changes. Its purpose is to ensure the stable operation of the library across different WWeb versions. * added: todo remove useOldImplementation * improved inner function to compare WWeb versions * inner function: added support for beta versions * added support for business accounts * module queries changed to strings * fixed check for wweb beta versions * updated to throw a custom error message * minor changes in inner function

* fix: Contact (pedroslopez#2325) * fixed: contact info retrieving * fixed: block method * fixed: isBlocked property is now changeble * added inner function to compare between WWeb versions The function compares the currently used WWeb version with the version that requires the code changes. Its purpose is to ensure the stable operation of the library across different WWeb versions. * added: todo remove useOldImplementation * improved inner function to compare WWeb versions * inner function: added support for beta versions * added support for business accounts * module queries changed to strings * fixed check for wweb beta versions * updated to throw a custom error message * minor changes in inner function * feat: send photo/video as a view once message (pedroslopez#2317) * added isViewOnce property * docs updated * added usage example * fix: ESLint * feat: add new link with phone option without regen observer * feat: implement code regeneration observer * chore: revert .gitignore change * chore: .gitignore EOF * refactor: replace wrong `LinkingOption` param type with `object` * refactor: make qr handler use the new `linkingMethod.qr.maxRetries` * test: add new test cases for linking method * refactor: improve new code checking * test: replace number with a number provided in the `.env` * refactor: improve constructor typing * refactor: make never properties optional --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com>

* fixed: contact info retrieving * fixed: block method * fixed: isBlocked property is now changeble * added inner function to compare between WWeb versions The function compares the currently used WWeb version with the version that requires the code changes. Its purpose is to ensure the stable operation of the library across different WWeb versions. * added: todo remove useOldImplementation * improved inner function to compare WWeb versions * inner function: added support for beta versions * added support for business accounts * module queries changed to strings * fixed check for wweb beta versions * updated to throw a custom error message * minor changes in inner function

ALΞX added 4 commits July 2, 2023 17:38

fixed: contact info retrieving

1125e72

fixed: block method

944714c

fixed: isBlocked property is now changeble

09fd827

added inner function to compare between WWeb versions

50be3f9

The function compares the currently used WWeb version with the version that requires the code changes. Its purpose is to ensure the stable operation of the library across different WWeb versions.

alechkos force-pushed the fix-contact branch from 4f75024 to 50be3f9 Compare July 2, 2023 18:01

added: todo remove useOldImplementation

e88f984

alechkos force-pushed the fix-contact branch from 6a4fdf7 to d34da7d Compare July 3, 2023 05:17

improved inner function to compare WWeb versions

d517054

alechkos force-pushed the fix-contact branch from d34da7d to d517054 Compare July 3, 2023 06:21

inner function: added support for beta versions

b6ed8e1

guyzyl mentioned this pull request Jul 3, 2023

Syncing Contacts Not Working on Docker, Locally, or via Website guyzyl/whatsapp-contact-sync#100

Closed

This was referenced Jul 3, 2023

Update whatsapp-web.js version to non-merged fix guyzyl/whatsapp-contact-sync#105

Merged

Restore whatsapp-web.js version to latest guyzyl/whatsapp-contact-sync#106

Closed

added support for business accounts

7e90639

module queries changed to strings

94924a9

Matheus-Lima-Moreira approved these changes Jul 5, 2023

View reviewed changes

diegofemello approved these changes Jul 6, 2023

View reviewed changes

pedroherpeto approved these changes Jul 8, 2023

View reviewed changes

Matheus-Lima-Moreira approved these changes Jul 10, 2023

View reviewed changes

fixed check for wweb beta versions

3efcf43

alechkos force-pushed the fix-contact branch from 2beacc8 to 3efcf43 Compare July 12, 2023 22:44

ALΞX added 2 commits July 13, 2023 02:05

updated to throw a custom error message

db1380b

minor changes in inner function

7925581

toooong approved these changes Jul 14, 2023

View reviewed changes

soluque approved these changes Jul 14, 2023

View reviewed changes

T3uZ approved these changes Jul 19, 2023

View reviewed changes

tuyuribr approved these changes Jul 29, 2023

View reviewed changes

shirser121 approved these changes Jul 31, 2023

View reviewed changes

shirser121 merged commit c8c2f09 into pedroslopez:main Jul 31, 2023
1 check passed

alechkos mentioned this pull request Aug 2, 2023

Getter was called with undefined data #2372

Closed

1 task

shirser121 mentioned this pull request Aug 3, 2023

Problem isRegisteredUser #2349

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Contact #2325

fix: Contact #2325

alechkos commented Jul 2, 2023 •

edited

T3uZ commented Jul 2, 2023

ivanzigoni commented Jul 3, 2023 •

edited

alechkos commented Jul 3, 2023 •

edited

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023 •

edited

PedroLGaldino commented Jul 3, 2023 •

edited

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023 •

edited

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023 •

edited

alechkos commented Jul 4, 2023

Matheus-Lima-Moreira left a comment

dottovip commented Jul 5, 2023

diegofemello commented Jul 6, 2023

hldpzz commented Jul 7, 2023

fenchai23 commented Jul 10, 2023

T3uZ commented Jul 10, 2023

Mr-Nobody1 commented Jul 28, 2023

alechkos commented Jul 28, 2023 •

edited

Mr-Nobody1 commented Jul 29, 2023

shirser121 commented Jul 30, 2023

shirser121 left a comment

fix: Contact #2325

fix: Contact #2325

Conversation

alechkos commented Jul 2, 2023 • edited

PR Details

- Description

- Motivation and Context

- Related Issues

- How Has the PR Been Tested

- Types of Changes

Description

Motivation and Context

Related Issues

How Has This Been Tested

Tested On

Types of accounts:

Environment:

To test this PR by yourself you can run one of the following commands:

If you encounter any issues while testing this PR, please provide in a comment:

Types of Changes

Checklist

T3uZ commented Jul 2, 2023

ivanzigoni commented Jul 3, 2023 • edited

alechkos commented Jul 3, 2023 • edited

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023 • edited

PedroLGaldino commented Jul 3, 2023 • edited

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023 • edited

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023

PedroLGaldino commented Jul 3, 2023

alechkos commented Jul 3, 2023 • edited

alechkos commented Jul 4, 2023

Matheus-Lima-Moreira left a comment

Choose a reason for hiding this comment

dottovip commented Jul 5, 2023

diegofemello commented Jul 6, 2023

hldpzz commented Jul 7, 2023

fenchai23 commented Jul 10, 2023

T3uZ commented Jul 10, 2023

Mr-Nobody1 commented Jul 28, 2023

alechkos commented Jul 28, 2023 • edited

Mr-Nobody1 commented Jul 29, 2023

shirser121 commented Jul 30, 2023

shirser121 left a comment

Choose a reason for hiding this comment

alechkos commented Jul 2, 2023 •

edited

ivanzigoni commented Jul 3, 2023 •

edited

alechkos commented Jul 3, 2023 •

edited

alechkos commented Jul 3, 2023 •

edited

PedroLGaldino commented Jul 3, 2023 •

edited

PedroLGaldino commented Jul 3, 2023 •

edited

alechkos commented Jul 3, 2023 •

edited

alechkos commented Jul 28, 2023 •

edited