Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in nodejs v12.x #2389

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Fix error in nodejs v12.x #2389

merged 4 commits into from
Aug 24, 2023

Conversation

ricardoapaes
Copy link
Contributor

PR Details

Error running on nodejs 12.x

Description

Error running on nodejs 12.x

How Has This Been Tested

Fix tested on my computer and running.

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@tuyuribr
Copy link
Collaborator

We should take a look here: #2129

@ricardoapaes
Copy link
Contributor Author

ricardoapaes commented Aug 10, 2023 •
edited
Loading

We should take a look here: #2129

@tuyuribr But the version released yesterday still promises support and unfortunately doesn't.

My software is compiled and runs on windows and node 14+ no longer supports windows 7, only 12.x.

https://stackoverflow.com/questions/62212754/latest-nodejs-compatible-with-windows-7

@beetechbr beetechbr mentioned this pull request Aug 11, 2023
Closed
1 task
shirser121
shirser121 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@shirser121 shirser121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tuyuribr
tuyuribr approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@tuyuribr tuyuribr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEsted on node 18, worked

@tuyuribr tuyuribr enabled auto-merge (squash) August 23, 2023 13:22
@tuyuribr tuyuribr disabled auto-merge August 23, 2023 13:23
@tuyuribr
Copy link
Collaborator

@ricardoapaes, merge the main branch

@ricardoapaes
Copy link
Contributor Author

Updated

@ricardoapaes
Copy link
Contributor Author

@tuyuribr

@tuyuribr tuyuribr merged commit 20dad1b into pedroslopez:main Aug 24, 2023
1 check passed
allerallegro pushed a commit to allerallegro/whatsapp-web.js that referenced this pull request Aug 25, 2023
@ricardoapaes
Fix error in nodejs v12.x (pedroslopez#2389)
e7a5952
@tuyuribr tuyuribr mentioned this pull request Aug 28, 2023
Open
6 tasks
@ricardoapaes ricardoapaes deleted the node12_support branch August 28, 2023 18:07
matiascamiletti pushed a commit to Tots-Agency/whatsapp-web.js that referenced this pull request Aug 30, 2023
@ricardoapaes @matiascamiletti
Fix error in nodejs v12.x (pedroslopez#2389)
3f965c9
dlimars pushed a commit to somosversotech/whatsapp-web.js that referenced this pull request Nov 7, 2023
@ricardoapaes @dlimars
Fix error in nodejs v12.x (pedroslopez#2389)
cad3be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuyuribr tuyuribr tuyuribr approved these changes

@shirser121 shirser121 shirser121 approved these changes

@pedroslopez pedroslopez Awaiting requested review from pedroslopez

@aliyss aliyss Awaiting requested review from aliyss

@PurpShell PurpShell Awaiting requested review from PurpShell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ricardoapaes @tuyuribr @shirser121