fix: client.destroy() keeps trying to get QR code when client is not authorized yet. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
reviewed
Jun 8, 2020
src/Client.js
Outdated
| @@ -118,11 +118,12 @@ class Client extends EventEmitter { | |||
| this.emit(Events.QR_RECEIVED, qr); | |||
| }; | |||
| getQrCode(); | |||
| let retryInterval = setInterval(getQrCode, this.options.qrRefreshIntervalMs); | |||
| this.retryInterval = setInterval(getQrCode, this.options.qrRefreshIntervalMs); | |||
There was a problem hiding this comment.
Looks good! One small thing I would change is make this variable more descriptive since it's now available on client. Please change this throughout the code :)
Suggested change
| this.retryInterval = setInterval(getQrCode, this.options.qrRefreshIntervalMs); | |
| this._qrRefreshInterval = setInterval(getQrCode, this.options.qrRefreshIntervalMs); |
|
LGTM! |
maznabili
added a commit
to maznabili/whatsapp-web.js
that referenced
this pull request
Jun 10, 2020
fix: clear qr refresh interval on client.destroy() (pedroslopez#249)
Belfio
pushed a commit
to Belfio/whatsapp-web.js
that referenced
this pull request
Jan 9, 2024
* fix: client.destroy() keeps trying to get QR code when client is not authorized yet Co-authored-by: Javier Portillo <javier.marquez@dada-dada.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.