Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delete lines that remove data from this._data #2958

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

shirser121
Copy link
Collaborator

PR Details

This PR removes lines in our codebase that delete specific properties from this._data.
We want to keep the _data as similer to the original message as possiable

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@shirser121
Copy link
Collaborator Author

@alechkos

Copy link
Collaborator

@alechkos alechkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PurpShell PurpShell merged commit 8c810a8 into main Apr 29, 2024
2 checks passed
@PurpShell PurpShell deleted the shirser121-patch-1 branch April 29, 2024 07:59
diegofemello added a commit to diegofemello/whatsapp-web.js that referenced this pull request Apr 30, 2024
Fix: delete lines that remove data from this._data (pedroslopez#2958)
ninajika pushed a commit to KDevRev/whatsapp-web.js that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants