Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: guide link fix and detailed description #2972

Merged
merged 5 commits into from Apr 22, 2024

Conversation

qzdark
Copy link
Contributor

@qzdark qzdark commented Apr 18, 2024

PR Details

Description

Due to updates in the guide, the link broke. I also added a banner to make it look similar to the guide's readme. Additionally, changed link inclusion and revised text for better clarity, aligning it with the descriptive style used in the guide's descriptions.

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

Due to updates in the guide, the link broke. I also added a banner to make it look similar to the guide's readme. Additionally, changed link inclusion and revised text for better clarity, aligning it with the descriptive style used in the guide's descriptions.
alechkos

This comment was marked as outdated.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alechkos alechkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good af

@qzdark
Copy link
Contributor Author

qzdark commented Apr 19, 2024

The banners will receive another update in the future to make them look even better and cleaner. However, the link should remain the same, so everything is fine.

@alechkos
Copy link
Collaborator

The banners will receive another update in the future to make them look even better and cleaner. However, the link should remain the same, so everything is fine.

Nice :)

Copy link
Collaborator

@aliyss aliyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliyss aliyss merged commit 6d4ec61 into pedroslopez:main Apr 22, 2024
1 check passed
scaranaraa added a commit to scaranaraa/whatsapp-web.js that referenced this pull request Apr 23, 2024
style: guide link fix and detailed description (pedroslopez#2972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants