feat: add received vcards to the message #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
requested changes
Oct 26, 2020
There was a problem hiding this comment.
I think the issue with this solution is that the body property would no longer always be a string type, which could cause issues for people using the library if they're expecting this type.
Maybe we should just add a property that has the vcard array, like what WhatsApp is doing on their end.
|
Sure, you're right. |
lucasrosa90
changed the title
lucasrosa90
changed the title
pedroslopez
approved these changes
Nov 5, 2020
Belfio
pushed a commit
to Belfio/whatsapp-web.js
that referenced
this pull request
Jan 9, 2024
close pedroslopez#398 Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#398