feat : Check if the given number is a whatsapp number #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sahalMoidu
commented
Feb 15, 2020
sahalMoidu
commented
- Avoids sending message to non whatsapp number (as it may lead to blocking by whatsapp)
- Gets the id of the user from whatsapp server rather than generating on client
Implemented changes mentioned in SimiPrambos PR#28 (pedroslopez#52)
- Avoids sending message to non whatsapp number - Gets the id of the user from whatsapp server rather than generating on client
pedroslopez
requested changes
Feb 15, 2020
pedroslopez
requested changes
Feb 15, 2020
|
404 meaning the not found. Its the same message whatsapp sends back This is the first time I'm working with Puppeteer and I don't know the best way to pass the error to the nodejs side. Could you recommend one. |
|
It’s fine, you could still throw it on the chrome side but make it more descriptive. The 404 doesn’t really say what’s wrong, maybe something like “The number provided is not a registered WhatsApp user.” |
|
Have updated the error message. I too wanted to push the error directly to the node side so the user can better handle it. I think using emitting the error through events would be a better paradigm. |
|
Yeah we could do an event. We can address that in another pr or issue though. |
Belfio
pushed a commit
to Belfio/whatsapp-web.js
that referenced
this pull request
Jan 9, 2024
* feat : Check if the given number is a whatsapp number - Avoids sending message to non whatsapp number - Gets the id of the user from whatsapp server rather than generating on client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.