update MessageMedia.fromUrl #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wictornogueira
commented
Aug 5, 2021
wictornogueira
commented
- fromUrl will now set filename based on the url (File name is null when using method MessageMedia.fromUrl() #808)
- Content-type is now used as fallback
Closed
|
Warning: if you download something from an empty path ( https://image.example.com/ ) fileName will be empty. but the chances of this happening seems very low |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
aliyss
approved these changes
Jan 21, 2022
dlimars
pushed a commit
to somosversotech/whatsapp-web.js
that referenced
this pull request
Jan 31, 2022
* fix MessageMedia.fromUrl docs * use content-type as fallback * set filename based on url * fix empty filename * wrap expression in parentheses * hotfix * JSDoc fix * fix for jsdog * eslint gets retirement home Co-authored-by: Rajeh Taher <rajeh@reforward.dev> Co-authored-by: Aliyss Snow <33941859+Aliyss@users.noreply.github.com>
Belfio
pushed a commit
to Belfio/whatsapp-web.js
that referenced
this pull request
Jan 9, 2024
* fix MessageMedia.fromUrl docs * use content-type as fallback * set filename based on url * fix empty filename * wrap expression in parentheses * hotfix * JSDoc fix * fix for jsdog * eslint gets retirement home Co-authored-by: Rajeh Taher <rajeh@reforward.dev> Co-authored-by: Aliyss Snow <33941859+Aliyss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.