Enable executing screenshot task without running instrumentation #52
Conversation
|
|
||
| executeScreenshot.dependsOn(DownloadScreenshotsTask.name) | ||
| if (extension.runInstrumentation) { |
There was a problem hiding this comment.
It's fully possible I misunderstand this here but should the executeScreenshot task not depend on the RemoveScreenshotsTask (line 70) task unless runInstrumentation is true?
Since we're not pulling the screenshots from a device when the instrumentation is not run, we're likely in an environment where neither a device nor adb is available (which is the case in the original issue).
There was a problem hiding this comment.
You are correct, updated the PR.
| executeScreenshot.dependsOn(RemoveScreenshotsTask.name) | ||
| val extension = | ||
| project.getExtensions.getByType[ShotExtension](classOf[ShotExtension]) | ||
| if (extension.runInstrumentation) { |
There was a problem hiding this comment.
Cosmetically, this if-check and the next 2 vals could've gone inside the following if (extension.runInstrumentation), but generally looks good to me. Thanks!
There was a problem hiding this comment.
Agreed! I mostly wanted to get feedback on the approach, to make sure I'm going in the right direction.
|
@Laimiux @Android-s14 thank you so much for your contribution. The PR code is just perfect. I'd add some documentation about the usage of this new parameter extension as part of the readme, but I'm going to do it by myself while preparing the next library release. Thank you so much for your contribution 👏 |
|
I forgot to mention I didn't wait for the CI build to pass because we are using bitrise for this project and something changed on the configuration of the emulator and the build has been broken for a while. Sorry for the inconveniences. |
📌 References
🎩 What is the goal?
This allows you to integrate remote service such as Firebase Test Lab with screenshot reporting.
How is it being implemented?
We provide a flag to disable instrumentation tests that run as part of screenshot task suite.
User can now instead provide screenshot data in screenshots/screenshots-default folder and just call executeScreenshotTests.
How can it be tested?
runInstrumentationTestsflagexecuteScreenshotTests