ERP test project

Travis-ci https://travis-ci.org/github/pedsf1968/myerp

SonarCloud https://sonarcloud.io/dashboard?id=pedsf1968_myerp

Object

Implement unitary and integration tests for code improvement and debbuging. This project use Travis-Ci for continuous integration pipeline. The result can be see in the link below : https://travis-ci.org/github/pedsf1968/myerp

The code analyse is made by Sonar. The result can be see in the link below : https://sonarcloud.io/dashboard?id=pedsf1968_myerp

---

Clone project

The head of the Maven project is in src directory!! https://github.com/pedsf1968/myerp.git

---

Run test

Test environment

• Go to myerp/src directory
• Execute : mvn clean verify sonar:sonar
• Open browser on : https://sonarcloud.io/dashboard?id=pedsf1968_myerp

Production environment

• Go to myerp/docker/dev directory
• Execute : docker-compose up -d

Access PostgreSQL database

• Open browser on http://localhost:5050
• Enter login : admin@pgadmin.org
• Enter password : admin
• Server address : 10.5.0.2
• Server port : 5432
• Database : db_myerp
• User : usr_myerp
• Password : myerp

Access Jenkins

• Open browser on http://localhost:5000

• Enter login : jenkins

• Enter password : admin

• Launch pipeline Myerp

• Open browser on : https://sonarcloud.io/dashboard?id=pedsf1968_myerp

---

Bugs found

Package com.dummy.myerp.model.bean.comptabilite

Class EcritureComptable

getTotalCredit()

Method was returning getDebit() instead of getCredit(). ORIGINAL

vRetour = vRetour.add(vLigneEcritureComptable.getDebit());

CORRECTION

vRetour = vRetour.add(vLigneEcritureComptable.getCredit()); 

---

isEquilibree()

Method was using equals for BigDecimal comparison instead of compareTo(). ORIGINAL

boolean vRetour = this.getTotalDebit().equals(getTotalCredit());
return vRetour;

CORRECTION

return this.getTotalDebit().compareTo(getTotalCredit()) == 0;

---

Package com.dummy.myerp.consumer.db.helper

Class ResultSetHelper

getDate()

Method return the current date instead the ResultSet date. ORIGINAL

public static Date getDate(ResultSet pRS, String pColName) throws SQLException {
    Date vDate = pRS.getDate(pColName);
    if (vDate != null) {
        vDate = DateUtils.truncate(vDate, Calendar.DATE);
    }
    return vDate;
}

CORRECTION

public static Date getDate(ResultSet pRS, String pColName) throws SQLException {
    if (pRS==null || pColName==null) {
        throw new SQLException(ERROR_MESSAGE);
    }     
    return pRS.getDate(pColName);
}

---

Package com.dummy.myerp.consumer

sqlContext.xml

SQLinsertListLigneEcritureComptable

Miss comma between debit and credit in column declaration. ORIGINAL

<property name="SQLinsertListLigneEcritureComptable">
    <value>
        INSERT INTO myerp.ligne_ecriture_comptable (
            ecriture_id, ligne_id, compte_comptable_numero, libelle, debit
            credit
        ) VALUES (
            :ecriture_id, :ligne_id, :compte_comptable_numero, :libelle, :debit,
            :credit
        )
    </value>
</property>

CORRECTION

<property name="sqlInsertListLigneEcritureComptable">
    <value>
        INSERT INTO myerp.ligne_ecriture_comptable (
            ecriture_id, ligne_id, compte_comptable_numero, libelle, debit,
            credit
        ) VALUES (
            :ecriture_id, :ligne_id, :compte_comptable_numero, :libelle, :debit,
            :credit
        )
    </value>
</property>

---

Package com.dummy.myerp.business.impl.manager

Class ComptabiliteManagerImpl

updateEcritureComptable()

No EcritureComptable rules checking before update. ORIGINAL

public void updateEcritureComptable(EcritureComptable pEcritureComptable) throws FunctionalException {
    TransactionStatus vTS = getTransactionManager().beginTransactionMyERP();
    try {
        getDaoProxy().getComptabiliteDao().updateEcritureComptable(pEcritureComptable);
        getTransactionManager().commitMyERP(vTS);
        vTS = null;
    } finally {
        getTransactionManager().rollbackMyERP(vTS);
    }
}

CORRECTION

public void updateEcritureComptable(EcritureComptable pEcritureComptable) throws FunctionalException {
    this.checkEcritureComptable(pEcritureComptable);
    TransactionStatus vTS = getTransactionManager().beginTransactionMyERP();
    try {
        getDaoProxy().getComptabiliteDao().updateEcritureComptable(pEcritureComptable);
        getTransactionManager().commitMyERP(vTS);
        vTS = null;
    } finally {
        getTransactionManager().rollbackMyERP(vTS);
    }
}

---

Modifications

• Change Junit4 to Junit5 with AssertJ and Mockito.
• Use memory H2 database for testing.
• Replace java.util.Date with java.sql.Date
• add profiles production and sonar (see Profile section)

TODO

Package package com.dummy.myerp.business.impl.manager

Class ComptabiliteManagerImpl

• implement addReference method
• implement missing rules test and separate each rule methods.
• implement general checking method that call the others.

  public void checkEcritureComptable(EcritureComptable pEcritureComptable) throws FunctionalException {
        this.checkEcritureComptableUnit(pEcritureComptable);
        this.checkEcritureComptableRG2(pEcritureComptable);
        this.checkEcritureComptableRG3(pEcritureComptable);
        this.checkEcritureComptableRG5(pEcritureComptable);
        this.checkEcritureComptableRG6(pEcritureComptable);
        this.checkEcritureComptableRG7(pEcritureComptable);
    }

test-consumer

Implement test-consumer package as test-business to access database with Class :

• ConsumerTestCase
• SpringRegistry
• TestInitSpring

Rowmapper

Package com.dummy.myerp.consumer.dao.impl.db.rowmapper.comptabilite

Add Row Mapper SequenceEcritureComptableRM for table SequenceEcritureComptable.

DBN

Package com.dummy.myerp.consumer.dao.impl.db

Add class DBN (DataBase Name) for database culumn name centralisation.

datasource MAP

applicationContext.xml

Add TEST datasource for memory database in AbstractDbConsumer MAP.

<bean class="org.springframework.beans.factory.config.MethodInvokingFactoryBean">
    <property name="targetClass" value="com.dummy.myerp.consumer.db.AbstractDbConsumer"/>
    <property name="targetMethod" value="configure"/>
    <property name="arguments">
        <map>
            <entry value-ref="dataSourceMYERP">
                <key>
                    <value type="com.dummy.myerp.consumer.db.DataSourcesEnum">MYERP</value>
                </key>
            </entry>
            <entry value-ref="dataSourceTEST">
                <key>
                    <value type="com.dummy.myerp.consumer.db.DataSourcesEnum">TEST</value>
                </key>
            </entry>
        </map>
    </property>
</bean>

Separate datasource in :

• dataSourceContextPostgresql.xml
• dataSourceContextH2.xml

Add SQL script for H2 schema and data :

• db-shema.sql
• db-data.sql

Set database type property in pom parent

<profile>
   <id>production</id>
   <properties>
      <myerp.database>MYERP</myerp.database>
   </properties>
</profile>
<profile>
   <id>test-business</id>
   <properties>
      <myerp.database>TEST</myerp.database>
   </properties>
</profile>
<profile>
   <id>test-consumer</id>
   <properties>
      <myerp.database>TEST</myerp.database>
   </properties>
</profile>
<profile>
   <id>sonar</id>
   <properties>
      <spring.profiles.active>sonar</spring.profiles.active>
      <myerp.database>TEST</myerp.database>
   </properties>
</profile>

Set database type property in pom child

<plugin>
   <groupId>org.apache.maven.plugins</groupId>
   <artifactId>maven-surefire-plugin</artifactId>
   <configuration>
      <systemPropertyVariables>
         <databaseType>${myerp.database}</databaseType>
      </systemPropertyVariables>
   </configuration>
</plugin>

Change application context according to database type.

    private static final String CONTEXT_PROD_APPLI_LOCATION
          = "classpath:/com/dummy/myerp/consumer/bootstrapContext.xml";
    private static final String CONTEXT_TEST_APPLI_LOCATION
          = "classpath:/com/dummy/myerp/testconsumer/consumer/bootstrapContext.xml";
    
    private ApplicationContext contextAppli;

    private SpringRegistry() {
        super();
        DataSourcesEnum database = DataSourcesEnum.valueOf(System.getProperty("databaseType"));

        SpringRegistry.LOGGER.debug("[DEBUT] SpringRegistry() - Initialisation du contexte Spring");
        if (database.equals(DataSourcesEnum.MYERP)) {
            this.contextAppli = new ClassPathXmlApplicationContext(SpringRegistry.CONTEXT_PROD_APPLI_LOCATION);
        } else {
            this.contextAppli = new ClassPathXmlApplicationContext(SpringRegistry.CONTEXT_TEST_APPLI_LOCATION);
        }

        SpringRegistry.LOGGER.debug("[FIN] SpringRegistry() - Initialisation du contexte Spring : {}", database);
    }

In AbstractDbConsumer change request according to the database type to find next sequence number

public abstract class AbstractDbConsumer {
    private static final String POSTGRES_REQUEST = "SELECT last_value FROM %s";
    private static final String H2_REQUEST = "SELECT %s.NEXTVAL-1 FROM DUAL";

  protected <T> T queryGetSequenceValue(DataSourcesEnum pDataSourcesId,
                                                   String pSeqName, Class<T> pSeqValueClass) {
        String vSeqSQL;
        JdbcTemplate vJdbcTemplate = new JdbcTemplate(getDataSource(pDataSourcesId));

        DataSourcesEnum database = DataSourcesEnum.valueOf(System.getProperty("databaseType"));

        if(database.equals(DataSourcesEnum.MYERP)) {
            vSeqSQL = String.format(POSTGRES_REQUEST,  pSeqName);
        } else {
            vSeqSQL = String.format(H2_REQUEST,  pSeqName);
        }

        return vJdbcTemplate.queryForObject(vSeqSQL, pSeqValueClass);
    }
}

Profiles

A production profile was added to separate production PostgreSQL database from test environment. A sonar profile was added also for testing everything and launch Sonar analyse with sonar:sonar parameter in command line.

Profile production

Production profile use a PostgreSQL Docker database. Launch containers with docker-compose command below : docker-compose up -d

Launch test

Using Maven command test with the tag -P to specify the profile. mvn clean test -P production

Launch sonar analyse

Using Maven command verify with the tag -P to specify the profile and sonar:sonar to start sonar analyse. mvn clean verify sonar:sonar -P production

Profile test-consumer

Use in memory H2 database

Launch test

Using Maven command test with the tag -P to specify the profile. mvn clean test -pl myerp-consumer -P myerp-consumer --also-make

Launch sonar analyse

Using Maven command verify with the tag -P to specify the profile and sonar:sonar to start sonar analyse. mvn clean verify sonar:sonar -pl myerp-consumer -P myerp-consumer --also-make

Profile test-business

Use in memory H2 database

Launch test

Using Maven command test with the tag -P to specify the profile. mvn clean test -pl myerp-business -P myerp-business --also-make

Launch sonar analyse

Using Maven command verify with the tag -P to specify the profile and sonar:sonar to start sonar analyse. mvn clean verify sonar:sonar-pl myerp-business -P myerp-business --also-make

Profile sonar

Use in memory H2 database and run all tests.

Launch test

Using Maven command test with the tag -P to specify the profile. mvn clean test -P sonar

Launch sonar analyse

Using Maven command verify with the tag -P to specify the profile and sonar:sonar to start sonar analyse. mvn clean verify sonar:sonar -P sonar