Issue in IE

[wayferer]

Thanks for making this, it's great. However I ran into the following issue when implementing today and wondering if you have some thoughts?

{exception} Object doesn't support this action

and it points to:

WallopProto.createCustomEvent = function () {
    var _this = this;
    this.event = new CustomEvent('change', {
      detail: {
        parentSelector: _this.selector,
        currentItemIndex: Number(_this.currentItemIndex)
      },
      bubbles: true,
      cancelable: true
    });
  };

[peduarte]

Hey,

Can you show me your markup and your javascript (how you're instantiating the plugin?)

Thanks!

[wayferer]

Sure. I'm just calling it via:

var slider=new WallopSlider('.wallop-slider');

and html markup

<div class="wallop-slider wallop-slider--slide">
    <div>
        <ul class="wallop-slider__list">
            <li class="wallop-slider__item wallop-slider__item--current" style="background-image:url(resources/img/temp-gallery-large1.jpg);">
                <div class="captionContainer">
                    <div class="caption">
                    </div>
                </div>
            </li>
            <li class="wallop-slider__item wallop-slider__item" style="background-image:url(resources/img/temp-gallery-large2.jpg);">
                <div class="captionContainer">
                    <div class="caption">
                    </div>
                </div>
            </li>
            <li class="wallop-slider__item wallop-slider__item" style="background-image:url(resources/img/temp-gallery-large3.jpg);">
                <div class="captionContainer">
                    <div class="caption">
                    </div>
                </div>
            </li>
        </ul>
        <button class="wallop-slider__btn wallop-slider__btn--previous" disabled>Previous</button>
      <button class="wallop-slider__btn wallop-slider__btn--next">Next</button>
    </div>
</div>

[wayferer]

Maybe this will help? http://stackoverflow.com/questions/19345392/why-arent-my-parameters-getting-passed-through-to-a-dispatched-event/19345563#19345563

[peduarte]

Hey! Thanks.

I've been really busy and haven't had time to fix anything! :(

Can you do something for me?
Can you check this: http://www.pedroduarte.me/wallop-slider/custom-events.html
And see if your also get any errors when listening to custom events?

I am checking on Chrome 32 and Firefox 27 and it's fine.
Which browser are you suing and what version?

Thanks!

[wayferer]

No worries at all. If you don't get a chance in the next few days, I'll have a go over the weekend. Right now I'm only getting the error in IE11 and it seems to be an IE thing (it's also ok here in Chrome and Firefox).

[peduarte]

Hello,

This issue has been fixed and pushed.
I added a CustomEvent() pollyfill...

Damn IE!!!

:)

[wayferer]

Awesome! Can I trouble you for the minified version?

[peduarte]

I have decided to remove the minified version from here as I am not using Grunt or anything.

Next task is to clean up the repo, add Grunt, separate Demo folder, etc...

You can use a tool such as the one below to minify the code:
http://jscompress.com/

[wayferer]

Ok cool. Thanks again.

[wayferer]

So I have been doing some more testing and wanted to let you know that there are issues with IE8 (I don't test lower than that) with the CustomEvent(). The polyfill you added works great for IE9+. So my question is, are you wanting to support IE8?

[peduarte]

Hey there,

Sorry, no IE8 support.

Should add that to the docs.

Thank you!

[wayferer]

Ok thanks!