-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add off method #60
Add off method #60
Conversation
Hey @jamesfzhang i'm definitely opened to this. I'll do some tests to make sure it's working and then merge. Thanks! |
@peduarte Fantastic. I've been using this locally for testing and it works fine. Thanks! |
@@ -154,9 +154,11 @@ | |||
|
|||
// Method so it is nicer for the user to use custom events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace this comment with:
Method to bind custom event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Just updated the commit with comments. |
Nice one, thank you |
@jamesfzhang Hey, |
@peduarte You need to use a named function (as opposed to an anonymous function) like so: |
Ok, that's good. I'm happy with it! |
@peduarte Just updated the readme. Thanks! |
👍 |
What do you think? @peduarte See #59 for details. Thanks!