Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update method #70

Merged
merged 2 commits into from
Sep 22, 2016
Merged

Add update method #70

merged 2 commits into from
Sep 22, 2016

Conversation

honzabilek4
Copy link

Related to #69 I've added an update method which sets correct state of global variables after changing slider content.
Can you do a quick review? Isn't against the wallop philosophy?
I was also wondering about calling the method in the upper initialization part to save some lines of code. (but the name should be slightly different then)

@peduarte
Copy link
Owner

@honzabilek4 hey, thanks for this.

Couple of comments:

  1. This PR is now conflicting with master as i've since merged other PR's
  2. I don't like the repetition that is happening there currently.

What I mean is that your update method is running the same things that happens at the start of the script (https://github.com/honzabilek4/wallop/blob/25284f23b267469ec128fa2b6e422cc56538e0d6/js/Wallop.js#L42-L44)

Perhaps it'd be better to have them both rely on the same method?

Also, I'm not sure the name update is good enough... is there a better name? Maybe reset?
Don't know, just thinking out loud...

@honzabilek4
Copy link
Author

Yes, that's what I was talking about.
Name reset seems more appropriate to me. I will get rid of the repetition and create a new pull request then. Is that okay?

@peduarte
Copy link
Owner

@honzabilek4 yes that's fine. The CI tests are broken, please make sure you test it the package thoroughly.

I'll review it asap.

Thanks!

🍺

@honzabilek4
Copy link
Author

Hi,
I've added a new commit with the fix here instead of creating a new PR. All tests are passing and I've also tested it manually. Everything is working and should be fine. 😉

@peduarte
Copy link
Owner

Sweet, I'll take a look!

@peduarte peduarte merged commit 55841fa into peduarte:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants