Rails 4.2 compatibility? #116
Comments
|
The dropped support for 4.2 also bit me while working on an old site. It makes sense to not worry as much about Rails 4.2, but it would be useful to know if support is dropped in the 1.1 release. |
zspencer
added a commit
to zinc-collective/peek
that referenced
this issue
May 22, 2020
See: peek#116 In Rails 4.2, some notification payloads do not include headers. I'm not entirely sure how to run the tests against the 4.2 Gemfile, but I was able to figure out how to bypass the exception gently. If someone wants to point me towards how to actually solve the problem, I'd be down to try it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just wondering if Peek is still targeting compatibility with Rails 4. The gemspec requires
railtiesversion 4+ but the commit located here introduced code that only works in Rails 5+.That commit adds a reference to the app headers in the ActiveSupport notification payload for getting the request ID. Those headers were added in this commit which targeted Rails 5.0.
I'm not knowledgable enough with Rails internals to come up with a PR to make it work in Rails 4.
(e)
The text was updated successfully, but these errors were encountered: