Encode ids in mvreg #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peer-base uses Buffers for ids, which were getting serialized in strange ways so the mvreg CRDT wasn't converging when syncing. See: peer-base/peer-base#287 This fix encodes the ids to strings, using a similar method as what is used in the rga type.
|
@jimpick could you get the CI green? |
|
Seems like it was an old failure due to npm dependencies ... I re-ran the tests and it passed. |
|
BTW, I don't have merge rights, but this LGTM |
|
Okay, I merged it. I think the permissions are definitely screwy now. Do you plan to keep maintaining this one? I'll request collaborator access on this repo from IT, and then I can add you back. |
|
@jimpick yes, no worries, I can keep maintaining this. |
|
Excellent! I'm trying to get added as a collaborator, then theoretically I can add you back on as well. |
|
I tracked down admin rights, and added @pgte back in as an admin collaborator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer-base uses Buffers for ids, which were getting serialized in
strange ways so the mvreg CRDT wasn't converging when syncing.
See: peer-base/peer-base#287
This fix encodes the ids to strings, using a similar method as what
is used in the rga type.