-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shapshots should contain date #56
Comments
@diasdavid @pgte the list of snapshots for a doc are lost when the user refreshes the page, and we don't currently have timestamp info on the objects. Do you want the UI to add them to localstorage / or is it a peerpad-core responsibility? |
Right now peerpad-core only takes the snapshot, so it's up to the app to do whatever with it. |
@olizilla while you're at it, could you please make the hash link open in a new window? |
👍 note to self: fix #54 while we're in here. |
@pgte It is ok to store the snapshot hash and key in localStorage? I know this is an alpha with no security promises, but I still wanted to check. |
Yes, since each snapshot has it's own independent decryption key. Access to these doesn't compromise the "future" of the document. |
@pgte last question! Snapshots need to be keyed on current document, so I know which ones to load when we render a new pad. Is it sensible to use the readKey for the current doc, since the name is mutable. |
The document name should not change, you're probably thinking about the document title, so it's safe. In regards to the document title changing, let's track this on another issue, I've neglected this part. |
Ah, I think name and title are currently conflated in the UI. |
Also, please make the box bigger so that we can see the whole hash
The text was updated successfully, but these errors were encountered: