Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapshots should contain date #56

Closed
daviddias opened this issue Oct 25, 2017 · 9 comments
Closed

Shapshots should contain date #56

daviddias opened this issue Oct 25, 2017 · 9 comments
Assignees

Comments

@daviddias
Copy link
Contributor

image

Also, please make the box bigger so that we can see the whole hash

@olizilla olizilla self-assigned this Oct 25, 2017
@olizilla
Copy link
Collaborator

@diasdavid @pgte the list of snapshots for a doc are lost when the user refreshes the page, and we don't currently have timestamp info on the objects. Do you want the UI to add them to localstorage / or is it a peerpad-core responsibility?

olizilla added a commit that referenced this issue Oct 25, 2017
@pgte
Copy link
Collaborator

pgte commented Oct 25, 2017

Right now peerpad-core only takes the snapshot, so it's up to the app to do whatever with it.
(Later on we plan to store docs and have a directory view, but right now that's still a bit fuzzy.. (at least for me)).

@pgte
Copy link
Collaborator

pgte commented Oct 25, 2017

@olizilla while you're at it, could you please make the hash link open in a new window?

@olizilla
Copy link
Collaborator

👍

note to self: fix #54 while we're in here.

@olizilla
Copy link
Collaborator

@pgte It is ok to store the snapshot hash and key in localStorage? I know this is an alpha with no security promises, but I still wanted to check.

@pgte
Copy link
Collaborator

pgte commented Oct 25, 2017

Yes, since each snapshot has it's own independent decryption key. Access to these doesn't compromise the "future" of the document.

@olizilla
Copy link
Collaborator

@pgte last question! Snapshots need to be keyed on current document, so I know which ones to load when we render a new pad. Is it sensible to use the readKey for the current doc, since the name is mutable.

@pgte
Copy link
Collaborator

pgte commented Oct 25, 2017

The document name should not change, you're probably thinking about the document title, so it's safe.

In regards to the document title changing, let's track this on another issue, I've neglected this part.

@olizilla
Copy link
Collaborator

Ah, I think name and title are currently conflated in the UI. name is plucked from the the url, set as state, and then mutated when the user edits the title. I'll pull them apart.

olizilla added a commit that referenced this issue Oct 25, 2017
Prefetch snapshots from gateway to speed up first render.

Add local `createdAt` property to snapshots.

Fix #56
Fix #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants