Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Op return field in the send tab #3

Closed
peerchemist opened this issue Mar 20, 2021 · 7 comments
Closed

Op return field in the send tab #3

peerchemist opened this issue Mar 20, 2021 · 7 comments
Projects
Board of Wisdom
Milestone
0.2.0

Comments

@peerchemist
Copy link
Member

Send tab allows for amount and destination field so far. It would benefit some use cases should it offer a 'Metadata' field, ie op_return. This field should be hidden by default but in settings there should be an option which makes it visible.
@peerchemist peerchemist added this to the 0.2.0 milestone Mar 20, 2021
@ghost
Copy link

ghost commented Jun 28, 2021

I tried to add support for OP_RETURN transactions on dart-bitcoin/bitcoin_flutter few weeks ago, I hope they are going to merge it...

dart-bitcoin/bitcoin_flutter#56

@peerchemist
Copy link
Member Author

It's a relatively easy patch, we can actually already pick it up.

@ghost
Copy link

ghost commented Jun 29, 2021

Yes it is really trivial.
Do you think that someone should be allowed to perform OP_RETURN transactions alone or they must be always embedded with a monetary transaction?
Also what is the max size of data that can be ambedded with OP_RETURN in Peercoin?

@peerchemist
Copy link
Member Author

Do you think that someone should be allowed to perform OP_RETURN transactions alone or they must be always embedded with a monetary transaction?

They should be free to do whatever they want.

Also what is the max size of data that can be ambedded with OP_RETURN in Peercoin?

256 byte

@peerchemist
Copy link
Member Author

I tried to add support for OP_RETURN transactions on dart-bitcoin/bitcoin_flutter few weeks ago, I hope they are going to merge it...

dart-bitcoin/bitcoin_flutter#56

I see you are author of this PR. PR it against our fork please. We do not need to wait for the upstream.

https://github.com/Vesta-wallet/bitcoin_flutter

@ghost
Copy link

ghost commented Jun 30, 2021 •
edited by ghost

I see you are author of this PR.

I thought that a pull in the top level would have been propagated through the forks.

PR it against our fork please. We do not need to wait for the upstream.

Ok

@willyfromtheblock willyfromtheblock moved this from To do to In progress in Board of Wisdom Nov 8, 2021
@willyfromtheblock
Copy link
Member

solved with #111

Board of Wisdom automation moved this from In progress to Done Nov 18, 2021
willyfromtheblock added a commit that referenced this issue Oct 30, 2022
@willyfromtheblock
fix analyze #3
012e395
willyfromtheblock added a commit that referenced this issue Oct 30, 2022
@willyfromtheblock @sandakersmann
1.0.2 (#190)
8110fbe 
* bump

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 100.0% (338 of 338 strings)

Translation: Peercoin Flutter/Translations
Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/nb_NO/

* Translated using Weblate (Swedish)

Currently translated at 100.0% (338 of 338 strings)

Translation: Peercoin Flutter/Translations
Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/sv/

* Translated using Weblate (Danish)

Currently translated at 100.0% (338 of 338 strings)

Translation: Peercoin Flutter/Translations
Translate-URL: https://weblate.ppc.lol/projects/peercoin-flutter/translations/da/

* bumpidity

* fix reconnect loop for connectionstate change

* bump flutter logs

* upgrade kotlin

* upgrade analyze-test

* upgrade distribution

* fix analyze #3

* change jcenter() to mavenCentral()

* temp change flutter_logs to fork

Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Board of Wisdom
  
Done
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@peerchemist @willyfromtheblock