Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open files on different platforms #10

Closed
bzz opened this issue May 18, 2020 · 5 comments
Closed

open files on different platforms #10

bzz opened this issue May 18, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@bzz
Copy link

bzz commented May 18, 2020

Thank you for sharing the code for this tool!

Right now, it includes a hard-coded calls to linux-specific tool subprocess.call(('xdg-open', XXX)).

It would be nice to have other platforms supposted (e.g. mac OS) by refactoring that to the logic similar to https://golang.org/src/cmd/internal/browser/browser.go that calls the right tool on each platform.

Otherwise, right now, on mac OS the tool works, but one can not open any file as there is no xdg-open binary.

@peerdavid
Copy link
Owner

Thanks for your comment and the very useful link. I want to test windows as well but I don't have mac OS. I will implement it accordingly to the link posted above (without testing) for mac OS and comment it here when the implementation is published.

@peerdavid peerdavid added the bug Something isn't working label May 18, 2020
@peerdavid peerdavid self-assigned this Jun 9, 2020
@AaronDavidSchneider
Copy link

It seems that remapy crashs OSX. I just installed remapy on my mac using the install.sh file and launched it using the launch.sh. Next thing that happens is that my mac logs out and I need to log in back.
Maybe just add a small warning to your readme.

@peerdavid
Copy link
Owner

It seems that remapy crashs OSX. I just installed remapy on my mac using the install.sh file and launched it using the launch.sh. Next thing that happens is that my mac logs out and I need to log in back.
Maybe just add a small warning to your readme.

Thank you for this important information, I added a comment to the Readme.

ivovh added a commit to ivovh/remapy that referenced this issue Sep 17, 2020
@peerdavid
Copy link
Owner

This should now be fixed...

@MeltedMagic
Copy link

For those that still have an issue with xdg-open, change 'xdg-open' to 'open' in remapy/gui/file_explorer.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants