Incorrectly pick up cdn.blah.com.s3.amazonaws.com

[hongkongkiwi]

Parsing s3 domain urls seems to be incorrect:

For example: cdn.blah.com.s3.amazonaws.com
{ tld: 's3.amazonaws.com',
domain: 'com',
subdomain: 'cdn.blah' }

In this case, it should pick up .com from the right hand side (obviously), then amazonaws as the domain, with: cdn.blah.com.s3 as the subdomain

[hongkongkiwi]

So from looking through the public suffix list which you use, we they have a section for ICANN domains and private domains. In my code, I think it's appropriate to switch off processing of 'private' domains. I'll submit a pull request later for this option, it shouldn't significantly affect the code, just provide some extra options for those of us that need it.

[alsotang]

+1
just use icann domains

[alsotang]

I think we can provide a icann options, such as:

parseDomain("foo.blogspot.com", {icann: true}) => {domain: blogspot, subdomain: foo, tld: com}

[jhnns]

Shipped with 1.0.0