Fixed wrong content length when request body contains non-ascii characters #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! 👍 Haven't thought of that... I'll merge it as soon as I'm home, but it might be obsolete anyway as I'm trying to replace the http server with a stdin/stdout-solution. |
|
No problem at all, thanks for the great work. |
jhnns
added a commit
that referenced
this pull request
Jul 2, 2014
…ii-request Fixed wrong content length when request body contains non-ascii characters
|
Shipped with v0.1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Length is bytes and not necessarily string length. Using Buffer.byteLength(string) will always be correct. Ref stackoveflow question http://stackoverflow.com/questions/18692580/node-js-post-causes-error-socket-hang-up-code-econnreset