Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with email reports for internal errors #1023

Closed
vegu opened this issue Aug 18, 2021 · 2 comments · Fixed by #1028
Closed

Bug with email reports for internal errors #1023

vegu opened this issue Aug 18, 2021 · 2 comments · Fixed by #1028
Labels
bug Operations Operations Committee
Milestone

Comments

@vegu
Copy link
Contributor

vegu commented Aug 18, 2021

Describe the bug

Email report for internal errors appears to get get sent to incorrectly formatted recipient (u@peeringdb.com, u@peeringdb.com`)

This might be as simple as a configuration fix or might require code changes.

Looks like we are using django.utils.log.AdminEmailHandler which i believe uses the ADMINS setting to determine recipients.

@vegu vegu added bug Operations Operations Committee labels Aug 18, 2021
@vegu
Copy link
Contributor Author

vegu commented Aug 19, 2021

As part of #715 we rolled out some fixes to how the ADMINS setting is specified (it was definitely broken before), will run some tests to see if that fixed the issue on beta.

During investigation of this we also found that it might make sense to expose a separate setting for an ops specific email to be used to dispatch error messages to. Currently it uses the SERVER_EMAIL setting which is set to support@peeringdb.com.

SERVER_EMAIL is also used to specify the sender for emails sent to users, so should not be changed.

@vegu
Copy link
Contributor Author

vegu commented Aug 19, 2021

Can confirm that #715 seems to have fixed the issue with the malformed recipient address which makes the remaining scope of this ticket io expose a separate setting called OPERATIONS_EMAIL for an ops specific email address to dispatch error messages to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Operations Operations Committee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants