Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Network Type Field #1379

Closed
martinhannigan opened this issue Apr 23, 2023 · 14 comments
Closed

Deprecate Network Type Field #1379

martinhannigan opened this issue Apr 23, 2023 · 14 comments
Assignees

Comments

@martinhannigan
Copy link

Is your feature request related to a problem? Please describe.

In multiple discussions (see 1357 for example [https://github.com//issues/1357] ) it's difficult to agree on just what should be in the Network Type field. We do seem to agree it's out of date. We don't seem to agree what the update is.

Note: I volunteered to shepherd the overall issue and proposing an additional option which I separated from the initial issue in 1357 for clarity sake.

Who is affected by the problem?

Users of PDB

What is the impact?

Negligible. The out of date descriptions have been in place for quite some time.

Are there security concerns?

No

Are there privacy concerns?

No

Describe the solution you'd like

Deprecate Network Type.

Do you think this feature will require a formal design?

No.

Describe alternatives you've considered

Updating the types. Unlikely consensus on a solution. Supports being out of date.

Doing nothing. This is bad for PDB. Being modern and relevant is good.

Deprecating the field. Eliminates stale and less-useful data from the database. Improves clarity.

Could this feature request need support from the Admin Committee?

No.

What is the proposed priority?

Not urgent.

Provide a rationale for any/all of the above

It's old. Users have complained about it. Many have proposed solutions, so much so it indicates a lack of clarity of why it's needed. I suggest we close 1357 and deprecate the field entirely.

Additional context

Nothing to add.

@martinhannigan martinhannigan self-assigned this Apr 23, 2023
@arnoldnipper arnoldnipper added this to the 1 Decide milestone Apr 23, 2023
@arnoldnipper
Copy link
Contributor

-1 as we only recently introduced additional network types (Route Server, Network Services, Government, ...). Network types help to single out peers. If there are types which are irrelevant nowadays, we should find new categories and migrate existing types.

@martinhannigan
Copy link
Author

+1

@martinhannigan
Copy link
Author

@peeringdb/pc FYI

@peterhelmenstine
Copy link

-1 If 98% of users are using it then I think we should keep the field

@martinhannigan
Copy link
Author

martinhannigan commented Apr 25, 2023 via email

@mcmanuss8
Copy link
Contributor

I think we could benefit from talking to the community more about this field. Recently at $day_job I found someone keying off of this field to make decisions about what kind of network the ASN was, but given how we've seen confusion about which value to pick, I'm not confident that's ideal.

What I'd like to hear from folks out there is:

  • Who is consuming this field and for what purposes? Do they find it helpful/valuable or no? Do they find it's mostly accurate?
  • When setting this field, are people happy with the options presented to them? Do they want more nuance or a coarser definition?

@martinhannigan
Copy link
Author

martinhannigan commented Apr 25, 2023 via email

@peterhelmenstine
Copy link

Until we know what others are using it for I think it needs to stay because all we know is they're using it now for something or they wouldn't have used it in the first place.

@martinhannigan
Copy link
Author

I'm +1 here. @peeringdb/pc please vote so we can get it off the docket at our next call. Thanks!

@arnoldnipper
Copy link
Contributor

Still -1 ... which still totals to a -1

@peterhelmenstine
Copy link

Suggest table until the survey results come in.

@martinhannigan
Copy link
Author

martinhannigan commented Jun 18, 2023 via email

@arnoldnipper
Copy link
Contributor

arnoldnipper commented Jun 18, 2023

We should decide if thats needed on our next call. Doesn't look like it.

Exactly, this issue isn't needed. I can only come to teh conclusion that the Network Type Field should stay. Look at the survey results (140 by now)

  • a majority is using the Network Type field when making decisions
  • 2/3 belief the values are accurate
  • 3/4 belief that the currently available options are useful

Users have spoken. We should follow. If we like or not,

@martinhannigan
Copy link
Author

At the PC meeting of 7/6/2023 the PC agreed to close this issue. A survey was completed which indicated interest in keeping the field. Shift over to Issue #1357 if you want to participate in it's journey forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants