Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb_load_data no longer creates necessary org usergroups #1480

Closed
vegu opened this issue Dec 8, 2023 · 1 comment · Fixed by #1551
Closed

pdb_load_data no longer creates necessary org usergroups #1480

vegu opened this issue Dec 8, 2023 · 1 comment · Fixed by #1551
Assignees
Labels
bug Time:Minor Up to 4 hours

Comments

@vegu
Copy link
Contributor

vegu commented Dec 8, 2023

Describe the bug

We use pdb_load_data to sync developer instances and the tutorial instance with data from the api.
We upgraded to use the new peeringdb client to handle the sync logic, however since that now does batch inserts this no longer triggers the necessary signals for organization user groups to be created during import.

This effects developers wanting to import data into their instance as well as the tutorial server which also uses this command to get up to date data once in a while.

To Reproduce
Steps to reproduce the behavior:

  1. run manage.py pdb_wipe
  2. run manage.py pdb_load_data
  3. go to /cp/auth/group/ and note that all the organization groups are missing

Expected behavior
Wiping and importing data via pdb_load_data should create all the necessary organization user groups for the orgs it imports.

Who is affected by the problem?
Developers, users of the tutorial server

Are there security concerns?
No

Are there privacy concerns?
No

What are the proposed actions?
Make sure pdb_load_data calls all the necessary signals. Double check signals.py if anything else is missing.

@vegu vegu added bug Time:Minor Up to 4 hours labels Dec 8, 2023
@grizz
Copy link
Member

grizz commented Dec 8, 2023

Verified bug.

@grizz grizz added this to the 4 Ready for Implementation milestone Dec 8, 2023
@leovegoda leovegoda self-assigned this Feb 12, 2024
vegu pushed a commit that referenced this issue Feb 20, 2024
pdb_load_data no longer creates necessary org usergroups #1480
API list net documentation says "org" is a string, but it actually contains a dictionary #1438
Allow users to edit their objects Geocode #1464
@vegu vegu mentioned this issue Feb 20, 2024
grizz pushed a commit that referenced this issue Feb 20, 2024
* Add field ixf_ixp_import_enabled to object ixlan #1229
pdb_load_data no longer creates necessary org usergroups #1480
API list net documentation says "org" is a string, but it actually contains a dictionary #1438
Allow users to edit their objects Geocode #1464

* escape lat lng input

* only notify for `ok` facilities

linting

---------

Co-authored-by: 20C <code@20c.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Time:Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants