Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IX-F Importer Blocker: "Days until DeskPRO ticket is created" should now be ignored/removed, such that no ticket or emails happen after a delay #860

Closed
ccaputo opened this issue Oct 16, 2020 · 17 comments · Fixed by #868
Assignees
Labels
AC Admin Committee bug Time:Minor Up to 4 hours
Milestone

Comments

@ccaputo
Copy link
Contributor

ccaputo commented Oct 16, 2020

As part of the Importer rollout, the current setting for "Days until DeskPRO ticket is created" is 6. After 6 days passed since SeattleIX began testing the Importer, all of the remaining conflicts were turned into DeskPRO tickets as designed. A problem is that this also resulted in 28 separate emails (the number of conflicts remaining) being sent to the SeattleIX PoC email. I think this is a huge problem and will result in upsetting many IXes if not corrected. Only a single email should have been sent to the SeattleIX PoC email, for a given Importer run.

Just as initial emails sent by the Importer are consolidated, so must any emails sent after the "Days until DeskPRO ticket is created" period has passed, regardless of whether to an IX or a Network.

I have disabled the Importer cron task for now, to avoid hundreds of separate emails being sent to the other IXes participating in the initial testing.

@ccaputo ccaputo added the bug label Oct 16, 2020
@vegu vegu added Time:Minor Up to 4 hours and removed Time:Minor Up to 4 hours labels Oct 16, 2020
@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 16, 2020

@vegu: Please hold off on this, until policy becomes further determined.

@ccaputo ccaputo assigned ccaputo and unassigned vegu Oct 16, 2020
@arnoldnipper arnoldnipper assigned arnoldnipper and unassigned ccaputo Oct 16, 2020
@arnoldnipper arnoldnipper added this to the 1 Decide milestone Oct 16, 2020
@arnoldnipper arnoldnipper added AC Admin Committee and removed bug labels Oct 16, 2020
@arnoldnipper
Copy link
Contributor

I'm completely fine with sending emails only once and then forget. This also makes life for @peeringdb/ac much easier

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 16, 2020

I'm completely fine with sending emails only once and then forget. This also makes life for @peeringdb/ac much easier

Can you clarify? We need to be explicit. Are you saying the following?:

Importer T-0 - conflict discovery:

  • Consolidated email to IX containing multiple conflicts discovered during this Importer run.
  • Consolidated email to Network containing multiple conflicts discovered during this Importer run.
  • DeskPRO ticket created for each conflict in which there is a missing PoC, such that email couldn't be sent.

Importer T-6+ - conflict 6+ days old:

  • Do nothing. (code gets revised to no longer do the following after 6 days: no DeskPRO ticket, no longer email IX, no longer email Network)

@arnoldnipper
Copy link
Contributor

I'm saying: just forget about anything after having sent emails after conflict discovery.

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 16, 2020

I'm saying: just forget about anything after having sent emails after conflict discovery.

@arnoldnipper, to be clear, you agree with #860 (comment) ?

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 20, 2020

@arnoldnipper has privately reconfirmed, so @vegu we are good to proceed with the changes detailed at: #860 (comment)

@ccaputo ccaputo assigned vegu and unassigned arnoldnipper Oct 20, 2020
@ccaputo ccaputo added the bug label Oct 20, 2020
@ccaputo ccaputo changed the title IX-F Importer Blocker: Emails sent after "Days until DeskPRO ticket is created" must be consolidated IX-F Importer Blocker: "Days until DeskPRO ticket is created" should now be ignored/removed, such that no ticket or emails happen after a delay Oct 20, 2020
@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 20, 2020

@vegu, please keep the code around albeit commented, as able, in case we revisit this at some point.

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 20, 2020

@vegu, in addition to the below, we need to remove the text from various emails (or elsewhere?) which says: "The Peering Admin Committee will assist with this conflict if it is not resolved in [%d] days."

I recommend changing this to say:

  • "The Peering Admin Committee may assist with this conflict if it is not resolved in a timely manner."

Importer T-0 - conflict discovery:

  • Consolidated email to IX containing multiple conflicts discovered during this Importer run.
  • Consolidated email to Network containing multiple conflicts discovered during this Importer run.
  • DeskPRO ticket created for each conflict in which there is a missing PoC, such that email couldn't be sent.

Importer T-6+ - conflict 6+ days old:

  • Do nothing. (code gets revised to no longer do the following after 6 days: no DeskPRO ticket, no longer email IX, no longer email Network)

@vegu vegu added the Time:Minor Up to 4 hours label Oct 20, 2020
@vegu
Copy link
Contributor

vegu commented Oct 21, 2020

@ccaputo

DeskPRO ticket created for each conflict in which there is a missing PoC, such that email couldn't be sent.

In the instance where only one party is missing a PoC (e.g., ix has poc, net doesn't - or vice versa) do we still want to send individual emails to the party that has the PoC set to join them into the DeskPRO ticket conversation?

@arnoldnipper
Copy link
Contributor

@vegu, we are currently redesigning what actions to be taken from IX-F JSON imports. Hence, moving forward does not make much sense imho

@mcmanuss8
Copy link
Contributor

I'm a bit confused by this thread, sorry.

It sounds like there were two options on the table:

a) After 6 days, make deskpro tickets, remember which ones you made for which IX. Make one email to each affected IX listing out all the deskpro issues we created (presumably in that cron run)
b) After 6 days, don't email anyone, just silently make deskpro tickets

@ccaputo was proposing A and @arnoldnipper was proposing B (maybe I should have made these options A and C ;)). Do we have consensus between the two of you on which would be preferable? If so, I'm happy to +1 either option, as they are both fine by me.

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 21, 2020

@ccaputo

DeskPRO ticket created for each conflict in which there is a missing PoC, such that email couldn't be sent.

In the instance where only one party is missing a PoC (e.g., ix has poc, net doesn't - or vice versa) do we still want to send individual emails to the party that has the PoC set to join them into the DeskPRO ticket conversation?

@vegu, if that is what was being done before, I'd say leave as is.

@vegu, we are currently redesigning what actions to be taken from IX-F JSON imports. Hence, moving forward does not make much sense imho

@arnoldnipper, I find this confusing and not explicit in regards to what you are saying does not make sense to move forward with.

I'm a bit confused by this thread, sorry.

It sounds like there were two options on the table:

a) After 6 days, make deskpro tickets, remember which ones you made for which IX. Make one email to each affected IX listing out all the deskpro issues we created (presumably in that cron run)
b) After 6 days, don't email anyone, just silently make deskpro tickets

@ccaputo was proposing A and @arnoldnipper was proposing B (maybe I should have made these options A and C ;)). Do we have consensus between the two of you on which would be preferable? If so, I'm happy to +1 either option, as they are both fine by me.

@mcmanuss8, I don't believe this to be the case. I triple checked #860 (comment) with @arnoldnipper, and thus I believe that is what we should implement for this round if we want to make progress in a way that will result in the Importer roll out to continue in a timely fashion. Further refinements with respect to subsequent messaging to conflicts can happen independent of this issue, and with consensus.

@arnoldnipper
Copy link
Contributor

I don't agree. So far there is no pressure from the community. Hence, I'm all for it to redesign the behaviour as proposed by email. We can come to an agreement quickly

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 21, 2020

@ccaputo

DeskPRO ticket created for each conflict in which there is a missing PoC, such that email couldn't be sent.

In the instance where only one party is missing a PoC (e.g., ix has poc, net doesn't - or vice versa) do we still want to send individual emails to the party that has the PoC set to join them into the DeskPRO ticket conversation?

@vegu, if that is what was being done before, I'd say leave as is.

@vegu to be clear, this is in regards to any DeskPRO ticket created at the time of conflict discovery. That remains. What is changing is the 6 day timer is going away, along with any DeskPRO tickets (and emails) that would have been created after 6 days.

I don't agree. So far there is no pressure from the community. Hence, I'm all for it to redesign the behaviour as proposed by email. We can come to an agreement quickly

@arnoldnipper let's take this to email. @vegu, I am sorry to say, but you can stop work on this issue 860.

@arnoldnipper
Copy link
Contributor

👍

@arnoldnipper
Copy link
Contributor

@vegu, we are currently redesigning what actions to be taken from IX-F JSON imports. Hence, moving forward does not make much sense imho

I withdraw. Please go ahead!

@ccaputo
Copy link
Contributor Author

ccaputo commented Oct 23, 2020

@vegu, we are currently redesigning what actions to be taken from IX-F JSON imports. Hence, moving forward does not make much sense imho

I withdraw. Please go ahead!

@vegu, please do the following for this issue:

  • Change this text which goes out in initial conflict discovery "The PeeringDB Admin Committee will assist with this conflict if it is not resolved in [%d] days." to be "The PeeringDB Admin Committee may assist with this conflict if it is not resolved in a timely manner." (NOTE the change from "Peering" to "PeeringDB", along with the removal of the number of days.)

  • Delete the environment setting: "IX-F Importer: Days until DeskPRO ticket is created"

  • Disable the activities that previously happened as a result of that environment setting. Ie. at Importer T-N+ - conflict N+ days old: Do nothing. (code gets revised to no longer do the following after 6 days: no DeskPRO ticket, no longer email IX, no longer email Network)

Please advise if questions. Thanks!

@grizz grizz mentioned this issue Nov 3, 2020
@grizz grizz closed this as completed in #868 Nov 4, 2020
@grizz grizz assigned grizz and unassigned vegu Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AC Admin Committee bug Time:Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants