Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvent approval of a facility by deleting and re-adding #922

Closed
arnoldnipper opened this issue Jan 22, 2021 · 7 comments · Fixed by #980
Closed

Circumvent approval of a facility by deleting and re-adding #922

arnoldnipper opened this issue Jan 22, 2021 · 7 comments · Fixed by #980
Assignees
Labels
AC Admin Committee bug Time:Minor Up to 4 hours

Comments

@arnoldnipper
Copy link
Contributor

A user may circumvent the approval of a facility by deleting when in status "pending" and then re-adding. The status then changes from "deleted" to "ok" instead of "pending".
20210122-Version-History-PeeringDB

@peeringdb/pc please make up your mind. @peeringdb/ac you may also want to comment

@arnoldnipper arnoldnipper added bug AC Admin Committee labels Jan 22, 2021
@arnoldnipper arnoldnipper added this to the 1 Decide milestone Jan 22, 2021
@arnoldnipper arnoldnipper self-assigned this Jan 22, 2021
@mcmanuss8
Copy link
Contributor

Feels like a clear bug - do we need to discuss? +1 if so

@job
Copy link
Contributor

job commented Jan 22, 2021

+1

@arnoldnipper
Copy link
Contributor Author

Maybe related to or the same as "Creating a facility that matches the name of a soft-deleted facility will cause the entry to bypass the verification queue" #901

@peterhelmenstine
Copy link

seems like a bug to me

@Yo-Robinson
Copy link

Yo-Robinson commented Jan 28, 2021 via email

@grizz
Copy link
Member

grizz commented Jan 28, 2021

Clear bug (and +1 anyway).

@egfrank
Copy link
Contributor

egfrank commented Jan 28, 2021

Summary

  • Fix bug where if a user deletes a status "pending" fac, they can re-add it and it will be status "ok" (should be "pending")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AC Admin Committee bug Time:Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants