Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify low-level DOM API #5

Closed
mitar opened this issue Mar 29, 2015 · 2 comments
Closed

Simplify low-level DOM API #5

mitar opened this issue Mar 29, 2015 · 2 comments

Comments

@mitar
Copy link
Member

mitar commented Mar 29, 2015

Current API with folding and aleady* flags is cumbersome. It is questionable how much composability it really offers. Maybe it would be better to simply allow each mixin to guide calling through getFirstMixin and getNextMixin (see #3). And maybe those methods should simply check the status of the DOM before doing anything. If they observe that DOM was already inserted, they do not do anything, for example. Or do it differently.

So in some way communication between mixins would work through node objects themselves. Similarly to how we communicate between event handlers by calling methods on the event object itself.

mitar added a commit that referenced this issue Mar 31, 2015
@mitar
Copy link
Member Author

mitar commented Mar 31, 2015

Fixed with c2ad456.

@mitar mitar closed this as completed Mar 31, 2015
@mitar
Copy link
Member Author

mitar commented Mar 31, 2015

Simplified API so that mixins are just called in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant