Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we call mixins always in life-cycle hooks #6

Closed
mitar opened this issue Apr 2, 2015 · 0 comments
Closed

Should we call mixins always in life-cycle hooks #6

mitar opened this issue Apr 2, 2015 · 0 comments

Comments

@mitar
Copy link
Member

mitar commented Apr 2, 2015

Currently, we are calling them from the life-cycle methods, allowing user to do things before, after, or event not call super. But if they forget to call super, mixins are not called. The question is if we really want to allow not calling them. Or do this customization of allowing to do things before or after is even a good one.

We could just have it so that mixins are always called, and then methods are called, which are empty by default.

(Same for DOM changes hooks?)

Order could match the same order of calling events. See #4. But while for events we have to decide when to call them because of unclear way how to offer customization. Leaving mixins calling in methods could allow such customization. But it can introduce also silent errors.

@mitar mitar closed this as completed in 463c7d7 Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant