Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we first attach component's event handlers then mixins'? #4

Closed
mitar opened this issue Mar 29, 2015 · 1 comment
Closed

Should we first attach component's event handlers then mixins'? #4

mitar opened this issue Mar 29, 2015 · 1 comment
Labels
discussion

Comments

@mitar
Copy link
Member

mitar commented Mar 29, 2015

Currently we are attaching mixins' first, then component's. See a1fdbc8. But this was just a gut feeling that it is more reasonable. What are arguments for and against for them?
@mitar mitar mentioned this issue Apr 2, 2015
Closed
@mitar
Copy link
Member Author

mitar commented Apr 6, 2015

After more thinking, the correct order is that components are first for everything, and then mixins. The idea is that mixins have most of the logic and anything defined on a component is overriding that default logic from mixins.

@mitar mitar closed this as completed Apr 7, 2015
mitar added a commit that referenced this issue Apr 7, 2015
@mitar
Unified order of components and mixins.
ef7f635 
Fixes #4 and fixes #11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitar