-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on Meteor Update 1.6.1 when using practicalmeteor:mocha #33
Comments
That's a bug in your app. This package is not using |
(It uses it only in tests. And dependency is defined here.) |
So Uses when running test on the package???
S Tunji Turner
sightuary
@sightuary
… On Feb 25, 2018, at 7:18 AM, Mitar ***@***.***> wrote:
(It uses it only in tests.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
But the dependency is defined in |
Yeah but the package is setup for version 1.4+, I am running into the error using version meteor 1.6.1
S Tunji Turner
sightuary
@sightuary
… On Feb 25, 2018, at 7:28 AM, Mitar ***@***.***> wrote:
But the dependency is defined in package.js.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Just packages versions uses from 1.4 Anyway, I cannot reproduce your issue. I ran this on Meteor 1.6.1 and tests work for me. |
So please create a small reproduction. |
Will do thanks
S Tunji Turner
sightuary
@sightuary
… On Feb 25, 2018, at 7:40 AM, Mitar ***@***.***> wrote:
So please create a small reproduction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I just removed the package, the app is a migration from 1.2 to 1.6.1.
S Tunji Turner
sightuary
@sightuary
… On Feb 25, 2018, at 7:40 AM, Mitar ***@***.***> wrote:
So please create a small reproduction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
OK, but can you make a small app where this is failing like you are describing? |
Yes I can
S Tunji Turner
sightuary
@sightuary
… On Feb 25, 2018, at 11:24 AM, Mitar ***@***.***> wrote:
OK, but can you make a small app where this is failing like you are describing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
And on command
|
And:
|
It is necessary to refrain while from using. |
So nobody willing to create a reproduction? |
Because things work for me:
|
Version of the meteor what? |
@atomoc, I do not understand your question. |
Meteor v.1.6.1 ? |
Yes, this is what I just ran, which uses Meteor 1.6.1 by default. Please try to create a small reproduction yourself and put a repo on GitHub. |
On a clean project with the same package.json and .meteor/packages files everything is ok, until I can understand what the problem is. |
Again my test app deployed as well , with the dependency
S Tunji Turner
sightuary
@sightuary
… On Feb 27, 2018, at 7:11 AM, Сергей Савельев ***@***.***> wrote:
On a clean project with the same package.json and .meteor/packages files everything is ok, until I can understand what the problem is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@stunjiturner, so does it work for you or no? I do not understand. |
It does not work for the existing app, only for a newly created meteor 1.6.1 test app.
S Tunji Turner
sightuary
@sightuary
… On Feb 27, 2018, at 12:15 PM, Mitar ***@***.***> wrote:
@stunjiturner, so does it work for you or no? I do not understand.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
OK. So please find what is the difference and make a reproduction. It works for me, so I cannot really help until we can at least have a small example. |
I tried to use ReactiveVar yesterday, but I got errors. Clearly something is not so simple with him. |
@mitar Here need a large reproduction most likely |
I think the problem is in Cordova |
This issue seems to happen when other conflicting packages have been installed, perhaps due to the way Meteor resolves conflicting dependencies? For example, having both 'practicalmeteor:mocha' and 'peerlibrary:reactive-publish' packages will result in this error. To replicate:
It seems the Meteor decides to install
Running
|
I'm seeing the same issue as @brendonboshell and can reproduce the same crash with the simple-todos as mentioned above. What I can't manage at the moment is to get node-inspector installed, apparently due to this issue: node-inspector/v8-debug#41 |
If anyone has had any luck in finding a solution to this I'd be very interested to hear it. Meanwhile, I note that an older version of my application using Meteor 1.6-beta.26 does not show this problem, so it does indeed seem to be related to 1.6.1. |
I am using this package with 1.6.1.1 without any problems. I think the issue is in I am using meteortesting:mocha which works well. |
Not sure why it is not picking 0.5.0 though for you. That version of this package uses CoffeeScript 1 and works well. |
See issue here: practicalmeteor/meteor-mocha#99 |
So can somebody try |
Ah, you get:
|
So not sure how to fix this. It is really a problem of |
Thanks for your further comments. Edit: The list of packages I'm using is at https://bitbucket.org/knirirr/beecount3/src/4652c46442fee9443c69be0722c485babd19c0ba/.meteor/packages?at=master&fileviewer=file-view-default |
You have now update all packages with |
I still see |
I've not checked in the changes I made locally, and don't plan to do so until I can get the application working again, so it still shows the old package. In addition to the package removal/addition previously mentioned I've also run
|
Yea, you have other dependencies on old CoffeeScript. You should really complain to Meteor about all this situation. They managed to break many libraries using CoffeeScript and many of them are not maintained really anymore. So try:
And you will see all conflicts.
So besides So there is not really much one can do here. Meteor broke that old already published packages do not work by forcing downgrade to broken versions. While new fixed packages require also other packages to be upgraded. And many are not maintained anymore. |
Thanks for looking into it - I'll see about pursing the issue elsewhere in case I get any luck. |
Accounts package moved to NPM: https://github.com/softwarerero/meteor-accounts-t9n#version-230 |
I am using this in my own apps with Meteor 1.6.1 and |
localCollectionLimit = new ReactiveVar(null);
Meteor 1.6.1 does not see the ReactiveVar inside the atmosphere package.
W20180225-07:01:23.344(-5)? (STDERR) ReferenceError: ReactiveVar is not defined
W20180225-07:01:23.344(-5)? (STDERR) at _fn (packages/peerlibrary_reactive-publish.js:421:5)
The text was updated successfully, but these errors were encountered: