Permissions UI #538
Permissions UI #538
Conversation
Still needs work on meta menus.
Conflicts: client/templates/publications.html
| if @membersCount is 1 then "1 member" else "#{ @membersCount } members" | ||
|
|
||
| Template.groupCatalogItem.public = -> | ||
| console.log @ |
|
Hm. I thought you also moved permissions display out of annotation menu? So that annotations would have icon of visibility next to the timestamp displayed. I would have an icon there and if you click it you get permission dialog. And then nothing about permissions is in menu. |
| Template.rolesControl.canModifyAccess = Template.accessControl.canModifyAccess | ||
|
|
||
| Template.rolesControlList.rolesList = -> | ||
|
|
|
Defaults in annotations? Will wait for you. :) Plenty of other work elsewhere. 👍 |
The issue is that we are pushing information out. So if one makes a public entity first, someone else can learn about it before entity is switched to private. By having it private, this cannot happen. And also by having private people will learn where they can configure privacy settings when they will want to share things.
|
OK, now about defaults. Point is, that we currently have already an API for setting defaults and I have a feeling that you put your code for defaults outside this API. So let me check now how to integrate this. |
Check for null explicitly. Return boolean instead of count. Don't throw an exception if user does not have access to the document.
|
For groups, also all group members can see the group. Should we expose that through on permission dialog? |
|
Or maybe it would be enough just to write in the case of groups that users listed below and members can see the group. |
For permissions, when access is private, maintainers and admins should also be added to read access list so that if access is changed to public and then their maintainer or admin permission is revoked, they still retain read access if document is after all that switched back to private access. We have this logic in applyDefaultAccess and setRole and they should match.
|
OK. I synced defaults. Now it looks LGTM to me, only for that group membership thing we should do something to not lie. |
Conflicts: client/collection.coffee client/group.coffee client/lib/access.coffee client/lib/catalog.coffee client/lib/controls.coffee client/publication.coffee Also renamed all e variables to event (see #375)
|
BTW, this is almost ready for merging? |
Done! Merge when travis passes? (edit: this should have been an assertive statement. :)) |
|
Yea! |
Among other things, fixes #482 and #450.