Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: add Blob and File support in 2.* #61

Closed
117503445 opened this issue Nov 28, 2023 · 2 comments · Fixed by #62
Closed

feature request: add Blob and File support in 2.* #61

117503445 opened this issue Nov 28, 2023 · 2 comments · Fixed by #62
Labels
released

Comments

@117503445
Copy link

117503445 commented Nov 28, 2023 •
edited
Loading

In version 1.0.1, support for Blob and File types was available. However, it seems that support for Blob and File types has been removed in version 2.0.0 after the introduction of TypeScript. The error message states, Type 'function Blob() { [native code] }' not yet supported.

Now that PeerJS is using the 2.0.0 version of js-binarypack, I would like to request the addition of support for Blob and File types in version 2.*.
@117503445 117503445 mentioned this issue Nov 28, 2023
Closed
@LetMeDream
Copy link

Hello there. Encountering the same issue on my side. Would really appreciate it if the feature could be added or if there's some workaround for it

LetMeDream added a commit to LetMeDream/Another-Chat that referenced this issue Dec 1, 2023
@LetMeDream
Downgrade peerjs to 1.3.2 in order to avoid issues peers/js-binarypac…
1e4dc74 
…k#61 and peers/peerjs#540
jonasgloning added a commit that referenced this issue Dec 3, 2023
@jonasgloning
feat: re-add Blob support
cd17d63 
`pack` will return a `Promise` when it packs a `Blob`
Switching to `bun test`. `jsdom` is annoying.

Closes #61
@jonasgloning jonasgloning mentioned this issue Dec 3, 2023
Merged
jonasgloning added a commit that referenced this issue Dec 3, 2023
@jonasgloning
feat: re-add Blob support (#62)
e79d1ee 
`pack` will return a `Promise` when it packs a `Blob`.

Closes #61
github-actions bot pushed a commit that referenced this issue Dec 3, 2023
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
68d89ea 
# [2.1.0](v2.0.0...v2.1.0) (2023-12-03)

### Features

* re-add Blob support ([cd17d63](cd17d63)), closes [#61](#61)
* re-add Blob support ([#62](#62)) ([e79d1ee](e79d1ee)), closes [#61](#61)
@jonasgloning
Copy link
Member

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: re-add Blob support peers/js-binarypack
3 participants
@LetMeDream @117503445 @jonasgloning